Description: When replacing single and double quotation marks with typographic ones, autocorrect works as it should when typing, but when this is someone uses the Tools, Autocorrect, Apply menu item, quotation marks are not changed unless the defaults are changed and set manually. Steps to Reproduce: 1. Open a document that has straight single and double quotes. 2. Choose Tools, Autocorrect, Apply. (Nothing happens to the quotation marks) 3. Try typing quotation marks and, if they are set to be updated, they are automatically corrected. Actual Results: The quotation marks are not updated. Expected Results: The quotation marks are changed to typographic (curved) ones. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: The software should respect the localisation settings irrespective if it is while typing or when applied after.
I can't confirm with Version: 6.4.0.0.alpha1 (x64) Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile (https://wiki.documentfoundation.org/UserProfile) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present
Dear To Do, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping
Unfortunately, this Apply works only on paragraphs with Default paragraph settings, so you must change paragraph style to use it to correct quotation marks automatically. I think, this is a UI bug, so it would be better to change that for a question, or something else.
Confirmed with 7.2.0.0.alpha0+ Tools > AutoCorrect > Apply will apply quotes in Localized Options in a paragraph with "Default Paragraph Style", but will not convert quotes in a paragraph with "Text Body" paragraph style.
*** Bug 142438 has been marked as a duplicate of this bug. ***
>> Unfortunately, this Apply works only on paragraphs with Default paragraph Is it possible to do something about it? There is no way that a user can guess about it. I think this is a major issue because applying auto-correct becomes very difficult (if not impossible).
Changing summary as it affects _all_ autocorrect rules. Was already the case in 6.2: Version: 6.2.0.0.beta1 Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Also Windows: Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded I see this as a bug, not an enhancement. Why should it be limited to one style? Documentation mentions something about styles, but only about numbering: https://help.libreoffice.org/7.5/en-US/text/swriter/01/05150200.html
*** Bug 155018 has been marked as a duplicate of this bug. ***
I've taken a look into this bug, and here is the current AutoCorrect logic for non default paragraph style: If the current style is user defined, then AutoCorrect is applied according to whether "Replace Custom Styles" is checked. Else, if the style is not default paragraph style, then it is assumed that everything is well formatted. It will get into HAS_FMTCOLL state, where BuildText() is not correctly run. I can fix it by calling BuildText() properly. In the same fix, I'll prevent AutoCorrect from changing the style to "Text Body" mentioned in bug 90507.
Baole Fang committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1cff5c9db7e0d7cf7ae45b306deb963d95926d99 tdf#128192: Fix Tools/AutoCorrect/Apply It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/d380411c947e8fcc3887889497349f45f01c28ac (related) tdf#128192 remove mention of "Default PS" limitation
Seth Chaiklin committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/help/commit/2c6962858e4e4a5018940456a30fa2bd716313e5 (related) tdf#128192 remove mention of "Default PS" limitation
Verified with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069c7dc4e9706b40ca12d83d83f90f41cec948f8 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded Also works with custom PS. Thanks Baole Fang! A very useful improvement of AutoCorrect.