Bug 128333 - UI: Irregular icons for 'First page/Previous page/Next page/Last page' in new print dialog
Summary: UI: Irregular icons for 'First page/Previous page/Next page/Last page' in new...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Print-Dialog
  Show dependency tree / graph
 
Reported: 2019-10-23 07:49 UTC by Thomas Lendo
Modified: 2021-08-12 09:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2019-10-23 07:49:51 UTC 
The arrow icons for 'First page', 'Previous page', 'Next page' and 'Last page' at the bottom of the preview in the new print dialog looks irregular to the other UI elements (e.g. icons according to the user's icon style) and are different between first/last and previous/next. Previous/next arrows are smaller.

Suggestion:
Use the same arrow icons for the first/last/previous/next commands as they already exist in the print preview of Writer and Calc.

PS: First and last page arrows were added with bug 125130.
Comment 1 Heiko Tietze 2019-10-23 08:26:18 UTC 
Those are the stock icons gtk-goto-first, gtk-go-back, gtk-go-forward, and gtk-goto-last. The gotopage* nextpage* icons don't fit IMHO and I'm not sure we should avoid stock icons at all.

We changed it recently for bug 125130.
Comment 2 andreas_k 2019-10-23 08:31:49 UTC 
Yes the icon sizes should be always the same. I patched it yesterday:
https://gerrit.libreoffice.org/#/c/81355/

As it's an dialog and ok, help, cancel buttons use backend specific buttons, I don't see an issue use them also for Previous, Next, ... pages buttons.
Comment 3 Rizal Muttaqin 2019-10-23 11:07:23 UTC 
+1 for this request

OOT:
Similar to this issue, I have created one: https://bugs.documentfoundation.org/show_bug.cgi?id=128338
Comment 4 Heiko Tietze 2021-06-14 11:52:26 UTC 
Rizal suggests themable rather than stock icons, so let's replace it.

Code pointer:

 vcl/uiconfig/ui/printdialog.ui
Comment 5 Po-Yen Huang 2021-07-29 08:22:15 UTC 
(In reply to Heiko Tietze from comment #4)
> Rizal suggests themable rather than stock icons, so let's replace it.
> 
> Code pointer:
> 
>  vcl/uiconfig/ui/printdialog.ui

We should change <property name="icon-name">go-first</property> to <property name="icon-name">cmd/lc_movepagefirst.png</property> or something like this right?
Comment 6 Po-Yen Huang 2021-08-12 09:15:20 UTC 
(In reply to Po-Yen Huang from comment #5)
> (In reply to Heiko Tietze from comment #4)
> > Rizal suggests themable rather than stock icons, so let's replace it.
> > 
> > Code pointer:
> > 
> >  vcl/uiconfig/ui/printdialog.ui
> 
> We should change <property name="icon-name">go-first</property> to <property
> name="icon-name">cmd/lc_movepagefirst.png</property> or something like this
> right?

hmm, I can see lc_movepagefirst.png and sc_movepagefirst.png there, but I have no idea what's different between these two icon...