The arrow icons for 'First page', 'Previous page', 'Next page' and 'Last page' at the bottom of the preview in the new print dialog looks irregular to the other UI elements (e.g. icons according to the user's icon style) and are different between first/last and previous/next. Previous/next arrows are smaller. Suggestion: Use the same arrow icons for the first/last/previous/next commands as they already exist in the print preview of Writer and Calc. PS: First and last page arrows were added with bug 125130.
Those are the stock icons gtk-goto-first, gtk-go-back, gtk-go-forward, and gtk-goto-last. The gotopage* nextpage* icons don't fit IMHO and I'm not sure we should avoid stock icons at all. We changed it recently for bug 125130.
Yes the icon sizes should be always the same. I patched it yesterday: https://gerrit.libreoffice.org/#/c/81355/ As it's an dialog and ok, help, cancel buttons use backend specific buttons, I don't see an issue use them also for Previous, Next, ... pages buttons.
+1 for this request OOT: Similar to this issue, I have created one: https://bugs.documentfoundation.org/show_bug.cgi?id=128338
Rizal suggests themable rather than stock icons, so let's replace it. Code pointer: vcl/uiconfig/ui/printdialog.ui
(In reply to Heiko Tietze from comment #4) > Rizal suggests themable rather than stock icons, so let's replace it. > > Code pointer: > > vcl/uiconfig/ui/printdialog.ui We should change <property name="icon-name">go-first</property> to <property name="icon-name">cmd/lc_movepagefirst.png</property> or something like this right?
(In reply to Po-Yen Huang from comment #5) > (In reply to Heiko Tietze from comment #4) > > Rizal suggests themable rather than stock icons, so let's replace it. > > > > Code pointer: > > > > vcl/uiconfig/ui/printdialog.ui > > We should change <property name="icon-name">go-first</property> to <property > name="icon-name">cmd/lc_movepagefirst.png</property> or something like this > right? hmm, I can see lc_movepagefirst.png and sc_movepagefirst.png there, but I have no idea what's different between these two icon...
Created attachment 201799 [details] Bug 128333 -> fixed Replaced the navigation button icon for "Previous Page" in the Print Dialog with a consistent style, using the `sc_previouspage.png` from the elementary icon theme. - Updated `printdialog.ui` to reference `cmd/sc_previouspage` - Verified that all icons now match in size and style Follow-up: The Colibre theme could also include this icon for full consistency.
Replaced the navigation button icon for "Previous Page" in the Print Dialog with a consistent style, using the `sc_previouspage.png` from the elementary icon theme. - Updated `printdialog.ui` to reference `cmd/sc_previouspage` - Verified that all icons now match in size and style Follow-up: The Colibre theme could also include this icon for full consistency. Bug 128333 - UI: Irregular icons for 'First page/Previous page/Next page/Last page' in new print dialog
Replaced the navigation button icon for "Previous Page" in the Print Dialog with a consistent style, using the `sc_previouspage.png` from the elementary icon theme. - Updated `printdialog.ui` to reference `cmd/sc_previouspage` - Verified that all icons now match in size and style Follow-up: The Colibre theme could also include this icon for full consistency. tdf#128333 - UI: Irregular icons for 'First page/Previous page/Next page/Last page' in new print dialog
Rosalio: you can mark a report as fixed, when your code commit has been merged into the core, but all of this will become apparent in our first meeting. Also, please don't send multiple copies of the same comment.