Bug 128369 - Save button doesn't get enabled while modifying the document
Summary: Save button doesn't get enabled while modifying the document
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 128377 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-10-24 09:41 UTC by Xisco Faulí
Modified: 2019-10-28 10:00 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-10-24 09:41:14 UTC 
Steps to reproduce:
1. Open Writer
2. Writer anything

-> Save button is disabled

Reproduced in

Version: 6.4.0.0.alpha1+
Build ID: 6c6b00300c5430466804619394b84beea01b3187
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Kudos to Miklos for finding it
Comment 1 Xisco Faulí 2019-10-24 09:44:03 UTC 
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e37b70442ebf9e1628e7da16b7b6acf498897dee

author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-10-23 08:24:31 +0200
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-10-23 15:22:16 +0200
commit e37b70442ebf9e1628e7da16b7b6acf498897dee (patch)
tree 4c02f4b4be6c10d4ff2a8b99f4ab057670e4d80b
parent d5d96e04ad8014f3e68351ccb54221d9610b565b (diff)
Add document-level option to lock down save

Bisected with: bibisect-linux64-6.4 

Adding Cc: to Samuel Mehrbrodt
Comment 2 Oliver Brinzing 2019-10-24 17:37:07 UTC 
*** Bug 128377 has been marked as a duplicate of this bug. ***
Comment 3 Stefan_Lange_KA@T-Online.de 2019-10-27 10:12:18 UTC 
IMHO the bug was present only for one day - in the builds from 2019-10-24.
Older builds work fine and also the newer builds from 2019-10-25 .. -27, e.g. 
Version: 6.4.0.0.alpha1+ (x64) Build-ID: 2d748207d343bf97fac34261cafeaefd9d5fc74f from 2019-10-25.

I think the bug could be closed.
Comment 4 Samuel Mehrbrodt (allotropia) 2019-10-28 06:09:21 UTC 
Was fixed with https://cgit.freedesktop.org/libreoffice/core/commit/?id=f763f86035ed8feffeedd7cfaebe3e0a3390a86f
Comment 5 Xisco Faulí 2019-10-28 10:00:10 UTC 
Verified in

Version: 6.4.0.0.alpha1+
Build ID: c4d760b9edf0399955d30a0dfbe5f7b1b1ed37cb
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded