Bug 128428 - FILEOPEN: RTF: Incorrect length of space breaks tables
Summary: FILEOPEN: RTF: Incorrect length of space breaks tables
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0 target:6.5.0 target:6.4.0.1
Keywords: bibisected, bisected, filter:rtf, regression
Depends on:
Blocks:
 
Reported: 2019-10-28 12:05 UTC by Xisco Faulí
Modified: 2019-12-05 09:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (28.44 KB, application/rtf)
2019-10-28 12:05 UTC, Xisco Faulí
Details
comparison MSO 2010 and LibreOffice 6.4 Master (167.72 KB, image/png)
2019-10-28 12:05 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-10-28 12:05:07 UTC
Created attachment 155361 [details]
sample file

Steps to reproduce:
1. Open attached document

-> Some texts should be on the right of the cell. Every text in on the left. See comparison

Reproduced in

Version: 6.4.0.0.alpha1+
Build ID: c4d760b9edf0399955d30a0dfbe5f7b1b1ed37cb
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2019-10-28 12:05:39 UTC
Created attachment 155362 [details]
comparison MSO 2010 and LibreOffice 6.4 Master
Comment 2 Xisco Faulí 2019-10-28 12:12:09 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=24b04db5a63b57a74e58a7616091437ad68548ac

author	László Németh <nemeth@numbertext.org>	2019-08-08 18:04:47 +0200
committer	László Németh <nemeth@numbertext.org>	2019-08-24 11:37:51 +0200
commit 24b04db5a63b57a74e58a7616091437ad68548ac (patch)
tree 7aa22bbc24efacfc854231664077e8f8143bda8e
parent f693d23170036bd6116458e655c2f3b34b3cd926 (diff)
tdf#123703 RTF import: fix length of space character sequence

Bisected with: bibisect-linux64-6.4

Adding Cc: to László Németh
Comment 3 Xisco Faulí 2019-10-28 12:15:26 UTC
attachment 79648 [details] for bug 64864 is also affected by the this issue
Comment 4 Xisco Faulí 2019-10-28 12:27:47 UTC
attachment 140072 [details] from bug 115946 is also affected
Comment 5 László Németh 2019-11-11 10:38:58 UTC
tdf#128428 RTF: clean-up for longer space sequence mode

Fix regressions from commit 24b04db5a63b57a74e58a7616091437ad68548ac
(tdf#123703 RTF import: fix length of space character sequence).

It seems, longer space sequence is an obsolete RTF-only feature, eg.
new RTF documents created in MSO don't use it, but old RTF documents
still keep their layout (only in RTF).

- Only old-style (without \stshfdbch) or compatible (\stshfdbch31505)
  RTF documents get longer space sequences using a one-time conversion;

- because Writer always exports old-style RTF documents, to avoid of
  enlargement of space sequences of new-style RTF documents later, RTF
  import doesn't modify the RTF documents saved in Writer (checking
  \generator);

- text in monospaced font "Courier New" doesn't get longer space
  sequence (despite its \prq2 (not monospaced) font setting).
Comment 6 Commit Notification 2019-11-11 10:40:12 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/24f17f0336badfbba276c1e6713a89b4f9bb7cb8

tdf#128428 RTF: clean-up for longer space sequence mode

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-11-11 15:39:51 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/33d966ecc1f9fc44016cdeeed15dbaf6bda68eda

tdf#128428 RTF: fix for different product versions

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2019-11-13 10:47:28 UTC
Verified in

Version: 6.4.0.0.alpha1+
Build ID: 26b7ff2b6cc4def8ff7b02e223961534ba88e654
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@László Németh, thanks for fixing this issue!
Comment 9 Commit Notification 2019-12-04 13:47:57 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cd7241e3d2892c2a115265f842f464d017d7c7e1

tdf#128428 RTF: switch off longer space at \dntblnsbdb

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2019-12-05 09:24:15 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/37ce55f7970de7bfba1d4fc9128cc5198e030f88

tdf#128428 RTF: switch off longer space at \dntblnsbdb

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.