Download it now!
Bug 128439 - Fileopen ODT: Long post-processing of a file containing a large table
Summary: Fileopen ODT: Long post-processing of a file containing a large table
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Tables 132261
  Show dependency treegraph
 
Reported: 2019-10-28 19:17 UTC by Telesto
Modified: 2020-04-19 19:21 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
tail of terminal output, bibisect-linux-64-6.4 (2.81 KB, text/plain)
2019-10-31 01:48 UTC, Terrence Enger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-10-28 19:17:22 UTC
Description:
Fileopen ODT: Long post-processing of a file containing a large table 

Steps to Reproduce:
Steps to Reproduce:
1. Open attachment 149343 [details] (bug 123517)
2. Notice the CPU usage after the file shows up and lines of the table being redrawn

Actual Results:
Long post processing after file opens. Some lines in the table get redrawn

Expected Results:
CPU hammering should stop after opening in +/-9 seconds with GDI (and +/-18 seconds with OpenGL)


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Versie: 6.4.0.0.alpha1 (x86)
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU-threads: 4; Besturingssysteem: Windows 6.3 Build 9600; UI-render: GL; VCL: win; 
Locale : nl-NL (nl_NL); UI-taal: nl-NL
Calc: CL

but not in
Version: 6.3.0.0.beta1+ (x86)
Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Dieter 2019-10-30 08:14:51 UTC
I confirm it with

Version: 6.4.0.0.alpha1 (x64)
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded
Comment 2 Terrence Enger 2019-10-31 01:48:25 UTC
Created attachment 155414 [details]
tail of terminal output, bibisect-linux-64-6.4

Working in bibisect-linux-64-6.4 repository on debian-buster with
VCL=gtk3, I see that the bug entered LibreOffice in

    commit 058c406c1610df7e557b9405619388465d3f056b
    Author: Corentin Noël <corentin.noel@collabora.com>
    Date:   Fri Sep 20 18:30:15 2019 +0200

        gtk3: Depend on the window stylecontext
    
        Make all GtkStyleContext children of the one from the current toplevel
        and ensures that the scale factor is the same as the parent.
        Also make sure to load images using the right scaling factor.
    
        Change-Id: I491d79941690fc69171e9aac950493dcca7c78f2
        Reviewed-on: https://gerrit.libreoffice.org/79311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

The CPU times I deemed good for probed versions ranged from 8.71 to
10.938 seconds, and for versions I deemed bad from 15.06 to 17.553
seconds.

I am removing keyword bibisectRequest and adding keywords bibisected
and bisected.
Comment 3 Dieter 2019-10-31 08:11:36 UTC
(In reply to Terrence Enger from comment #2)
>     commit 058c406c1610df7e557b9405619388465d3f056b
>     Author: Corentin Noël <corentin.noel@collabora.com>
>     Date:   Fri Sep 20 18:30:15 2019 +0200

cc: Corentin Noël
Comment 4 Corentin Noël 2019-10-31 08:57:09 UTC
So the bug reports:
VCL: win
This commit only changed a behavior in GTK3 VCL 🤷‍♂️️
Comment 5 Terrence Enger 2019-10-31 15:37:26 UTC
(In reply to Corentin Noël from comment #4)
> So the bug reports:
> VCL: win
> This commit only changed a behavior in GTK3 VCL 🤷‍♂️️

My experience reported in comment 2 was all vith VCL:gtk3, which was
the default.  I did not try other values.

BTW, I have no opinion about whether the performance degradation is
serious, still less about the seriousness in comparison to the
benefits of the patch I pointed to.