Bug 128445 - Reflected images: what I see in the slides list and in the work area does not correspond to what I see in the display mode.
Summary: Reflected images: what I see in the slides list and in the work area does not...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-10-29 05:22 UTC by Anna Baroni
Modified: 2022-03-03 16:45 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
The last slide shows the problem I have already explained. Even if the file is exported to pdf the problem remains (2.53 MB, application/vnd.oasis.opendocument.presentation)
2019-10-29 05:38 UTC, Anna Baroni
Details
The example file in presentation mode under 7.3 (1.98 MB, image/jpeg)
2022-03-01 20:39 UTC, Gabor Kelemen (allotropia)
Details
PDF export of the example file (1.24 MB, application/pdf)
2022-03-01 20:40 UTC, Gabor Kelemen (allotropia)
Details
Smaller example file (41.96 KB, application/vnd.oasis.opendocument.presentation)
2022-03-02 20:47 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Baroni 2019-10-29 05:22:51 UTC
Description:
I was preparing an exercise on symmetries for my students. I cut a photo along the horizontal and vertical axis of symmetry to get a module. Then I copied the form and reflected it (Reflect sidebar command) both horizontally and vertically, to "reconstruct" the starting image. Everything works perfectly in the work mode, but in presentation mode the reflected images are no longer visible. So what I see in the slides list and in the work area does not match what I see in the display mode (in the Presentation mode).

Steps to Reproduce:
1.Crop a photo with many pixels.
2.Copy the cut image and use the reflect command to flip the image. 
3.Repeat several times.

Actual Results:
In the work mode everything works but in Presentation mode some images disappear.

Expected Results:
Show in presentation mode the same things I see in work mode


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
Comment 1 Anna Baroni 2019-10-29 05:38:05 UTC
Created attachment 155382 [details]
The last slide shows the problem I have already explained. Even if the file is exported to pdf the problem remains
Comment 2 Regina Henschel 2019-10-30 00:17:03 UTC
Vertical flip of metafile does not work in presentation mode.

Workaround: Use a bitmap instead of a metafile. (Context menu: Convert to Bitmap)
Comment 3 Xisco Faulí 2019-11-11 15:54:25 UTC
Actually this is a regression from

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7f9b0f47979dcb7abfed37bb7cd38ab51eac6011

author	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-10-30 16:29:09 +0100
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-04-17 02:05:57 +0200
commit 7f9b0f47979dcb7abfed37bb7cd38ab51eac6011 (patch)
tree 639b6289605dc4b108b70d2da56dd214e62a5be1
parent 0f93692fda4226323422cf82ce34ae4bd5e22fab (diff)
tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if needed

Bisected with: bibisect-linux64-6.1

Adding Cc: to Armin Le Grand
Comment 4 QA Administrators 2021-12-04 04:43:02 UTC Comment hidden (obsolete)
Comment 5 Gabor Kelemen (allotropia) 2022-03-01 20:39:35 UTC
Created attachment 178602 [details]
The example file in presentation mode under 7.3

This looks good in 7.3 bibisect master under Linux. Bibisect shows it got better in two changes:

https://git.libreoffice.org/core/+/446de9cbea55af65b5f1a274f1ac4b88a6be9ae6

author	Miklos Vajna <vmiklos@collabora.com>	Mon Sep 21 21:16:28 2020 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	Tue Sep 22 09:00:56 2020 +0200

tdf#136337 cairo canvas: fix missing image with negative height

This solved in 7.1 the vertical flip that was visible on the right half image of Slide 9.

https://git.libreoffice.org/core/+/bc0ab08634f59e1a1814e575fe6ad5e50bf1aee1%5E%21/#F10

author	Mike Kaganski <mike.kaganski@collabora.com>	Fri Nov 19 00:22:31 2021 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	Fri Nov 19 15:42:03 2021 +0100

Drop F_PI1800/F_PI18000, and unify deg2rad/rad2deg conversions

This solved the horizontal flip issue that was still present in the bottom left image on Slide 11
Comment 6 Gabor Kelemen (allotropia) 2022-03-01 20:40:33 UTC
Created attachment 178603 [details]
PDF export of the example file

Exported PDF is also looking good now.
Comment 7 Gabor Kelemen (allotropia) 2022-03-01 20:45:53 UTC
Looks good under Windows too:

Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 14; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Miklos, Mike: thanks for solving this issue :)
Comment 8 Xisco Faulí 2022-03-02 12:39:28 UTC
Hi Gabor, Regina,
I would like to create a unittest for this issue. However, the attached document is too large. I tried to create a minimizer sample but I failed. Could you please help to provide a minimized reproducer ?
Comment 9 Gabor Kelemen (allotropia) 2022-03-02 20:47:34 UTC
Created attachment 178623 [details]
Smaller example file

Hi Xisco

The second commit fixed the display of the PDF, that can be tested by this smaller reproducer.
The issue fixed by the first commit is also exhibited by this in slideshow mode, but only there.

I made this by following the instructions in the original example doc: insert my favourite tiny test jpg, copy+paste as GDI, then delete the jpg, crop the GDI, make another copy of it and flip the copy vertically, group with the original, then copy - paste the group and flip the copy horizontally.
Comment 10 Commit Notification 2022-03-03 16:45:28 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d04a04d76f8b813b3fc54195f95c7c53e01a1832

tdf#128445: vcl_pdfexport: Add unittest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.