Bug 128465 - Not possible to paste a picture from the clipboard on a slide in impress on iOS
Summary: Not possible to paste a picture from the clipboard on a slide in impress on iOS
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-29 15:32 UTC by Nicolas Christener
Modified: 2019-12-13 18:20 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Christener 2019-10-29 15:32:57 UTC
Description:
While it is possible to paste a picture from the clipboard into a writer document on iOS using the "Edit > Paste" menu entry it is not possible to do the same in impress.

Steps to Reproduce:
1. Copy a picture to the clipboard using e.g. the iOS browser
2. Create/open a slide deck using the iOS app
3. Try to paste the picture using the "Edit > Paste" menu entry

Actual Results:
It's not possible to paste a picture from the clipboard into the slide.

Expected Results:
It should be possible to paste a picture from the clipboard into the slide.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Xisco Faulí 2019-10-30 08:26:33 UTC
Moving to NEW
Comment 2 How can I remove my account? 2019-11-08 13:01:42 UTC
Looking at this now.
Comment 3 How can I remove my account? 2019-11-11 09:59:07 UTC
Note to self: Possibly the problem is caused by the iOS clipboard (of "pasteboard" as the term actually used in iOS and macOS is) code is too simple, and doesn't automatically convert incoming PNG and JPEG data to BITMAP, too. Just a guess. Debugging what happens on macOS to compare.
Comment 4 How can I remove my account? 2019-11-11 14:14:08 UTC
Note to self: On macOS it seems that regardless what kind of image you have copied to the pasteboard, it offers public.png. On iOS, not like that. If you copy a JPEG, the pasteboard has public.jpeg, if you copy a PNG, it has public.png.

(And if you do copy a PNG to the pasteboard, the iOS app can paste it just fine, as expected.)
Comment 5 How can I remove my account? 2019-11-12 12:51:35 UTC
Fix in https://gerrit.libreoffice.org/#/c/82507/ .

I am not entirely satisfied with it, it scares me a bit that the patch is in svtools, it might affect other unrelated use cases, and cause unintended regressions for other functionality. Hopefully unit tests will reveal any such.
Comment 6 Commit Notification 2019-11-13 12:57:07 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9c40a13144cdbb31791ee3e2e7340461a2520af2

tdf#128465: Enable pasting also JPEG images in presentation documents

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Nicolas Christener 2019-12-13 17:36:11 UTC
This now works as expected.

Tested with 4.2 (25) on iOS 13.3.x

I think this issue can be closed as fixed.

Thanks a lot to the Collabora team and especially to Tor for taking care of this.