Description: Tables in writer on iOS have a grey area left/above the table which is meant to select a column/row when taping on it. This does currently not work and the area above the second column always has a different style than the other grey areas (dashed lines instead of continuous lines). Steps to Reproduce: 1. Open/create a writer document using the iOS app 2. Add table to the document 3. Click into a cell to put the focus into the table 4. Try to select a column/row using the grey area between the table and the resize handles Actual Results: Taping on the grey area does not trigger the selection of the column/row. Expected Results: Taping on the grey area should trigger the selection of the column/row. Reproducible: Always User Profile Reset: No Additional Info:
Created attachment 155429 [details] Printscreen showing the grey area which should select a column/row
This is still an issue with the iOS app version 4.2.20 but it seems to be fixed in a pre-release of Collabora Online: LOOLWSD 4.1.99 (git hash 617886d) Served by: be7e8350 LOKit 6.2-1 (git hash df6296b) Maybe the issue does only happen with the "iOS app theme"?
This is one more of those bugs that probably are caused by changes in WebKit in iOS 13. Safari and WebKit in iOS 13 on iPad now strive to provide a more "desktop-like" browsing experience, and they also have added support for the PointerEvent things. One theory I have is that the ancient Leaflet code that we use is quite confused about PointerEvents and use them wrongly, or something. Hacks upon hacks of trying to adapt to specific browser and platform changes.
Based on some discussion I found on the web I tried to force the L.Browser.pointer to be false for us, but that had no effect.
Or then it is the Hammer thing for the whole document map that interferes. Tediously trying to trace event handing in Safari I see that the _onTap in loleaflet/src/map/handler/Map.TouchGesture.js gets called.
And also, in loleaflet/src/layer/tile/TileLayer.TableOverlay.js, the _onSelectRowColumnClick function is the handler only for the 'click' event, and apparently in this case no 'click' event will be generated when tapping on the column or row header. Or maybe some code deep down somewhere disables the generation of a such.
In a current build (also reproducible in "make run") there is another related problem: If the text document also contains a shape, and one selects the shape, after that it isn't possible to select the table at all... I feel like running away screaming.
(But that was caused by a recent commit in core and will hopefully be fixed soon. Not related to this bug.)
Suggested fix in https://gerrit.libreoffice.org/c/online/+/87079 . There are still some glitches, for instance resizing a column or row doesn't refresh the row and column headers rectangles.
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/ebaca16c4f28ae7a499c632b70b24eaaa1083439 tdf#128509: Make the column and row headers tappable on touch devices
This issue has been fixed and can be closed. Tested with 4.2 (32). Thanks a lot to the Collabora team and especially Tor for fixing this!