Bug 128741 - Always Wrong Icon Theme Selection In GTK3 Backend
Summary: Always Wrong Icon Theme Selection In GTK3 Backend
Status: RESOLVED DUPLICATE of bug 128979
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected
Depends on:
Blocks:
 
Reported: 2019-11-12 12:23 UTC by Rizal Muttaqin
Modified: 2019-12-11 23:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Wrong icon selection (247.06 KB, image/gif)
2019-11-27 19:01 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2019-11-12 12:23:06 UTC
I came across icon theme selection in 6.4 master build somehow always misleading.

Currently, we have several icon themes in core:
1. Breeze
2. Breeze (SVG)
3. Breeze dark
4. Colibre
5. Colibre (SVG)
6. Elementary
7. Elementary (SVG)
8. Karasa Jaga
9. Karasa Jaga (SVG)
10. Sifr
11. Sifr (SVG)
12. Sifr (dark)
13. Tango

When choosing one of the icon theme, it ends with the below one from I choose. For example if I choose elementary, then elementary (SVG) will be activated.

Step to Reproduce:
1. Open one of LibreOffice, select Tools > Options
2. In the LibreOffice(Dev), click View > Icon Style > choose one icon theme (e.g elementary) > Apply > OK. Then elementary chosen but elementary (SVG) activated
3. Close the Options dialog and reopen again then the active icon theme now is elementary (SVG)
Comment 1 Rizal Muttaqin 2019-11-12 12:23:23 UTC
Version: 6.4.0.0.alpha1+
Build ID: 4438e7dcbfd78b117b704fd4d15b2e445c3db0b0
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-11-10_11:21:37
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded
Comment 2 BogdanB 2019-11-19 12:06:04 UTC
Confirm it in 6.4 on Linux.
Comment 3 Rizal Muttaqin 2019-11-27 19:01:36 UTC
Created attachment 156159 [details]
Wrong icon selection

Look at the GIF file to see the in real action

Still reproducible in 6.5:

Version: 6.5.0.0.alpha0+
Build ID: e01df3488abe6d319c6874ca870afb82a3ad9b1e
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-11-25_14:20:57
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded
Comment 4 Rizal Muttaqin 2019-12-10 13:02:14 UTC
Could someone see any patch which turns this issue happens?

Since the selection is always go to the below, Breeze could not selected anymore if you activate other than Breeze. Me personally could bot check Breeze as  I would like to try maintain many icon theme here. As a workaround  I use qt5 as the backend now.
Comment 5 BogdanB 2019-12-10 20:08:58 UTC
I found where this problem is coming from:
 bc99cd5ceaa8016dec89a82a09d5839c7fe2feb0 is the first bad commit
commit bc99cd5ceaa8016dec89a82a09d5839c7fe2feb0
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Sep 20 21:36:59 2019 +0200

    source 94d6fa11d086187b82adf9aa596e0f334827e095
    
    source 94d6fa11d086187b82adf9aa596e0f334827e095

:040000 040000 7702153f1c9a1bca178218768bca9ee20f0f9c81 e45dddceaea5131365301c87e0e6c0a786f16f4b M	instdir
Comment 6 BogdanB 2019-12-10 20:12:31 UTC
Reviewed-by: Caolán McNamara 3 months ago.
Comment 7 Caolán McNamara 2019-12-10 20:32:39 UTC
sounds like the problem of bug 128979 which got fixed
Comment 8 BogdanB 2019-12-10 20:43:28 UTC
Verified on 
Version: 6.5.0.0.alpha0+
Build ID: 5030be4e85179147476b1e441eb618fb6ed58235
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-11-28_20:14:48
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded

It's ok. Sorry Caolán for this. I didnt check the last version.

*** This bug has been marked as a duplicate of bug 128979 ***
Comment 9 BogdanB 2019-12-10 20:44:29 UTC
Will be available also in 6.4.0.1.
Comment 10 Rizal Muttaqin 2019-12-11 23:50:03 UTC
OK it's resolved in

Version: 6.5.0.0.alpha0+
Build ID: d5d8fa63282a433da9c49d811f04390b8d6ab9cc
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-12-11_04:03:13
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

Thank you Bogdan and Caolan!