Description: References are incorrectly updated after deleting rows from an Excel generated xlsx document. Steps to Reproduce: 1. Open the attachment (xlsx file). 2. Check B1. Note that it references B30. 3. Delete an empty row between 2 and 29 (eg. the row 10). 4. Check B1 again, it now references B26 instead of B29. Actual Results: B1 references B26 after delete-row. Expected Results: B1 should reference B29 after delete-row. Reproducible: Always User Profile Reset: No Additional Info: Like B1 the cells C1, D1 and E1 are also affected by the bug after delete-row operation. The bug is XLSX import related, after saving the file as new XLSX and reloading the new one, the reference is updated correctly after the same steps. Version: 6.2.8.2 Build ID: 6.2.8.2-2.fc30 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded The bug is also present in latest master.
Created attachment 155940 [details] Document that can be used to reproduce the bug.
Dennis Francis committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b30251ca0d102ced36799ee18d4bbcd9e8530fa0 tdf#128894: xlsx-import : Do not share tokens between cells... It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dennis Francis committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/626d1527267ab856e516f2424173104f781b8f09 tdf#128894: unit test for the bugfix It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Backports are in gerrit pending CI.
Dennis Francis committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/c8459ed5e433418453f366504f86cc1c2b1bf011 tdf#128894: xlsx-import : Do not share tokens between cells... It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dennis Francis committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/035fdc06f22420412b10b2f969706a45ab582a02 tdf#128894: xlsx-import : Do not share tokens between cells... It will be available in 6.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dennis Francis committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/a297c6a8c71a8cb07ede3b2305760a1d41b9fb6a tdf#128894: unit test for the bugfix It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dennis Francis committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/88f0de823bb9bd186f7d9ef69041b64969531056 tdf#128894: unit test for the bugfix It will be available in 6.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Also reproducible in Version: 5.2.0.0.alpha1+ Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; Locale: ca-ES (ca_ES.UTF-8) I don't think there is an urgency to backport it to 6-3-4 branch
Verified in Version: 6.5.0.0.alpha0+ Build ID: d6e2d624a124454fa4ac80cb30a924571a609101 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Dennis Francis, thanks for fixing this issue!!