Bug 128966 - Writer table: Center Vertically shows some rows as Align Top (click-in restores until next fileopen)
Summary: Writer table: Center Vertically shows some rows as Align Top (click-in restor...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.8.2 release
Hardware: All All
: low minor
Assignee: Michael Stahl (CIB)
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Tables-Alignment
  Show dependency treegraph
 
Reported: 2019-11-22 15:18 UTC by Peter Lawson
Modified: 2020-03-23 12:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Programme (26.34 KB, application/vnd.oasis.opendocument.text)
2019-11-22 15:20 UTC, Peter Lawson
Details
document (26.12 KB, application/vnd.oasis.opendocument.text)
2019-11-23 14:16 UTC, Peter Lawson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Lawson 2019-11-22 15:18:55 UTC
Description:
If one selects e.g. centred-vertically in areas of a table, this formatting is very easily lost, for instance when another line is inserted

If a field is spread vertically over two lines, and the insertion of another line higher above forces the second line onto a new page, the split reappears and the lower section becomes protected (read-only) 

Steps to Reproduce:
1. Set centred-vertically on a line
2. Insert a new line above
3. Centreing disappears. Can be only be restored by changing to top then back to centre

Actual Results:
Centreing disappears

Expected Results:
Centreing should remain


Reproducible: Always


User Profile Reset: No



Additional Info:
Open Office behaves similarly
Comment 1 Peter Lawson 2019-11-22 15:20:58 UTC Comment hidden (obsolete)
Comment 2 Dieter 2019-11-23 09:50:33 UTC Comment hidden (obsolete)
Comment 3 Peter Lawson 2019-11-23 12:14:47 UTC Comment hidden (obsolete)
Comment 4 Dieter 2019-11-23 13:58:51 UTC Comment hidden (obsolete)
Comment 5 Peter Lawson 2019-11-23 14:16:11 UTC
Created attachment 156062 [details]
document
Comment 6 Peter Lawson 2019-11-23 14:23:23 UTC
I should have stated before that I was using 6.2.2. I have since installed 6.3.3.2 and there is an improvement. It is now only necessary to click on a defective row and the vertical centering re-appears. This is as you reported. Sadly, if I save and close the document, when I re-open it the problems are back.

How can I get 6.4.0.0 to test it?
Comment 7 Peter Lawson 2019-11-23 14:55:32 UTC
Installed 6.4.0.0. Clicking in row restores centreing, saved it in this condition, re-opened and problems returned
Comment 8 Timur 2019-11-24 09:13:45 UTC
Peter, your bug report is not clear. 
I change the wrong title (problems with document) to what I see here, although I don't understand: "Formatting: vertical alignment lost when row added to table"
Instead of two similar large documents, you should've attached minimal sample (just one page with few rows) with text explaining the issue (like: insert new row above this one"). 
Please be exact:
"1. Set centred-vertically on a line": How exactly did you do it? Which row?
"2. Insert a new line above": Above which row and content?
Comment 9 Peter Lawson 2019-11-24 13:03:29 UTC
The problem in fact only occurs when the document is saved. On re-loading, the incorrect vertical alignment re-appears, even though I fixed it prior to saving by clicking on the row

It does not happen on the first page of the document, so creating a table with a few rows is unlikely to reveal any error

"1. Set centred-vertically on a line": How exactly did you do it? Which row?

I did it by selecting the row and then clicking on the 'Centre Vertically' icon
Several rows are problematic, including most of those containing my name or 'Linda Rose'

"2. Insert a new line above": Above which row and content?

I am no longer sure that this is the cause of the problem

Fortunately, when exported to pdf, the result is perfect
Comment 10 Timur 2019-11-24 17:16:07 UTC
Report should've immediately pointed to: 'Linda Rose' and 'Peter Lawson ' in December 10 and 17, January 7 and 14.
I see now on fileopen in LO 6.5+ and 6.2.8. Not in LO 6.1.6. Regression.

Notes:
I see that those texts in table have two text:style-name tags.
Maybe this table was created with some content pasted from MSO or web.
Comment 11 Timur 2020-03-16 07:58:50 UTC
Steps:
1. open ODT attachment 156062 [details] 
2. both Win and Lin: see that some rows appear as Align Top:  'Linda Rose' and 'Peter Lawson ' in table December for 10 and 17, table January for 7 and 14.
3a. Windows: click in row changes them to Center Vertically OR
3b. Linux: add row above or below changes them to Center Vertically 
4. save and reopen, shows them again as Align Top

Bibisected:
54dcc59bd41665dfe5697ea05195b4ad0399dac9 is the first bad commit
commit 54dcc59bd41665dfe5697ea05195b4ad0399dac9
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri May 10 16:39:16 2019 +0200

    source sha:232b467083dd3b55f261bebe084e696bee200ec9

Previous:
commit 416803c1c47c9bca7cee66d28fff4d8e36e00430 (HEAD, refs/bisect/good-416803c1c47c9bca7cee66d28fff4d8e36e00430)
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri May 10 16:25:00 2019 +0200

    source sha:da5f9c68a253f28e9c0149e61b5662191a658af2

Single:
https://gerrit.libreoffice.org/plugins/gitiles/core/+/232b467083dd3b55f261bebe084e696bee200ec9%5E!/

commit	232b467083dd3b55f261bebe084e696bee200ec9	[log]
author	Michael Stahl <Michael.Stahl@cib.de>	Wed May 08 16:23:25 2019 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	Fri May 10 13:25:52 2019 +0200
tree	01a607d9f95780e407f10c7bec1862f0d4fb2a76
parent	da5f9c68a253f28e9c0149e61b5662191a658af2 [diff]

tdf#124675 sw: fix crash when moving SwTextFrame in table to prev page

CC: Michael. Please take a look if this needs to be fixed and if related to text:style-name tags.