Bug 129160 - Introduce low-level HiDPI scaling to properly show icons on high DPI screens (see comment 13)
Summary: Introduce low-level HiDPI scaling to properly show icons on high DPI screens ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.2.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 146701 (view as bug list)
Depends on:
Blocks: HiDPI
  Show dependency treegraph
 
Reported: 2019-12-03 15:09 UTC by maxloh.register
Modified: 2023-12-13 12:28 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshots from high DPI screen (Large icon) (82.49 KB, image/png)
2019-12-03 15:11 UTC, maxloh.register
Details
Notebookbar demo screenshot from official blog (109.60 KB, image/png)
2019-12-03 15:11 UTC, maxloh.register
Details
Screenshots from high DPI screen (Automatic icon size) (85.27 KB, image/png)
2019-12-04 16:45 UTC, maxloh.register
Details
Standard toolbar and tabbed compact layout (automatic icon size) (74.53 KB, image/png)
2019-12-04 17:56 UTC, maxloh.register
Details
Standard toolbar and tabbed compact layout (large icon size) (73.26 KB, image/png)
2019-12-04 17:57 UTC, maxloh.register
Details
SB Shapes deck Win10 on 4K display, os/DE scaling 350% (191.88 KB, image/png)
2023-12-12 17:45 UTC, V Stuart Foote
Details
Shapes Sidebar, Win10, 4K Display, os/DE scaling 175% (68.33 KB, image/png)
2023-12-13 09:24 UTC, bugzilla2
Details
SB Shapes deck Win10 on 4K display, os/DE scaling 125% (52.30 KB, image/png)
2023-12-13 12:28 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description maxloh.register 2019-12-03 15:09:33 UTC
Description:
On high DPI screen (like a 2k screen of Surface Pro 4), margin around icons is too narrow.
The resulted UI is ugly and different from the demo screenshot of Notebookbar from https://blog.documentfoundation.org/blog/2018/06/05/libreoffice-interview-andreas-kainz-talks-about-new-icons-and-the-notebookbar/.

Steps to Reproduce:
Enable notebookbar

Actual Results:
Icon padding is too narrow

Expected Results:
Icon padding is wider


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Comment 1 maxloh.register 2019-12-03 15:11:05 UTC
Created attachment 156269 [details]
Screenshots from high DPI screen (Large icon)
Comment 2 maxloh.register 2019-12-03 15:11:42 UTC
Created attachment 156270 [details]
Notebookbar demo screenshot from official blog
Comment 3 andreas_k 2019-12-03 22:31:10 UTC
Hi,

which icon size do you use (Automatic or something else?). See Burger Menu -> Options -> View Icon size for Notebookbar
Comment 4 maxloh.register 2019-12-04 16:45:28 UTC
Created attachment 156306 [details]
Screenshots from high DPI screen (Automatic icon size)
Comment 5 maxloh.register 2019-12-04 16:50:59 UTC
The setting while taking the screenshot was large.

After setting icon size to automatic, the problem still exist and furthermore, icons would become too small compared to the demo screenshot. 

I attached a screenshot with automatic icon size for your reference.
Comment 6 andreas_k 2019-12-04 17:04:40 UTC
Puh I understood your bug but I don't have a final idea how to fix is.

Only for testing can you use standard toolbar and tabbed compact layout.

Thanks for the feedback
Comment 7 maxloh.register 2019-12-04 17:48:43 UTC
(In reply to andreas_k from comment #6)
> Puh I understood your bug but I don't have a final idea how to fix is.
> 
> Only for testing can you use standard toolbar and tabbed compact layout.
> 
> Thanks for the feedback

What icon size do you need for the screenshot?
Comment 8 andreas_k 2019-12-04 17:53:22 UTC
whatever is best for you on hidpi
Comment 9 maxloh.register 2019-12-04 17:56:54 UTC
Created attachment 156307 [details]
Standard toolbar and tabbed compact layout (automatic icon size)
Comment 10 maxloh.register 2019-12-04 17:57:18 UTC
Created attachment 156308 [details]
Standard toolbar and tabbed compact layout (large icon size)
Comment 11 maxloh.register 2019-12-04 17:58:51 UTC
(In reply to andreas_k from comment #8)
> whatever is best for you on hidpi

Attached screenshots for both large and automatic icon size.

Thanks.
Comment 12 Heiko Tietze 2020-01-20 12:03:41 UTC
Any idea what kind of bug it is, Tomaz?
Comment 13 Tomaz Vajngerl 2020-03-27 10:02:10 UTC
Well in windows we use to manually change the UI elements depending on the scale factor. This approach means we would need to take everywhere the scaling factor into account (for all the margins and whatever). 
Compared to HiDPI scaling in GTK3, where this is all done in the lower levels so there it looks mostly the same as without HiDPI scaling. We decided some time ago that we would do the same for other backends or generally for VCL, but nobody worked on it yet.
Comment 14 bugzilla2 2022-09-01 16:17:57 UTC
Being a freshly HiDPI User, I sadly can confirm that bug. Lots of spacing and scaling issues. Fixing this on the root cause would be very welcome...
Comment 15 Stéphane Guillou (stragu) 2023-12-12 12:42:40 UTC
*** Bug 146701 has been marked as a duplicate of this bug. ***
Comment 16 Stéphane Guillou (stragu) 2023-12-12 12:44:46 UTC
Can someone affected by this issue see if they also see a more extreme symptom in the Shapes sidebar deck, as in attachment 177463 [details] (from bug 146701)?
Comment 17 V Stuart Foote 2023-12-12 17:45:03 UTC
Created attachment 191394 [details]
SB Shapes deck Win10 on 4K display, os/DE scaling 350%

(In reply to Stéphane Guillou (stragu) from comment #16)
> Can someone affected by this issue see if they also see a more extreme
> symptom in the Shapes sidebar deck, as in attachment 177463 [details] (from
> bug 146701)?

Yes issues of asymmetrical scaling of UI element on Windows os/DE UI scaling. Here the SB Shapes deck on os/DE scaled to 350% on a 4K display.  Same system with os/DE UI scaling 125% is comfortable to use all LO UI elements.
Comment 18 V Stuart Foote 2023-12-12 17:52:56 UTC
(In reply to V Stuart Foote from comment #17)

that was with recent build of master against 24.2.0
Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1a74a87b442857567d20da5dc97bbbc278745afd
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

RenderMethod: vulkan
Vendor: 0x10de
Device: 0x1380
API: 1.3.260
Driver: 546.4.0
DeviceType: discrete
DeviceName: NVIDIA GeForce GTX 750 Ti
Denylisted: no

On an LG 4K 32" monitor using display port 1.4
Comment 19 bugzilla2 2023-12-13 09:24:55 UTC
Created attachment 191403 [details]
Shapes Sidebar, Win10, 4K Display, os/DE scaling 175%

Here how it looks on my PC. 4k/27" Display, 175% scaling ...
Comment 20 V Stuart Foote 2023-12-13 12:28:56 UTC
Created attachment 191407 [details]
SB Shapes deck Win10 on 4K display, os/DE scaling 125%

(In reply to bugzilla2 from comment #19)
> Created attachment 191403 [details]
> Shapes Sidebar, Win10, 4K Display, os/DE scaling 175%
> 
> Here how it looks on my PC. 4k/27" Display, 175% scaling ...

Correct, and attached clip from 7.5.9.2 on same system as comment 17 with os/DE set to 125% UI scaling. 

So note, from the vertical separation of rows of shape icons, that the scale factor applied to the icons is not in sync and UI is progressively worse at higher UI scaling factors needed for HiDPI.

This issue is for implementing element scaling (not just the SB decks) for the Widows VCL backend, i.e. at a lower-level.