Created attachment 156355 [details] Strong blue border Steps to reproduce: 1. Create a new text document / open up Writer 2. Create a new page 3. Print preview one of the page (File > Print Preview (Ctrl+Shift+O) Currently Writer use strong blue color to indicate active selected page which is not pleasant nor elegant to my eyes. Please consider to change it to a lighter blue or remove it completely. IIRC Word does not show any border in the Print Preview as well as WPS Writer.
Created attachment 156356 [details] WPS Writer's Print Preview No any page border color in WPS Writer
I would consider this as an enhancement. cc: Design-Team
Good catch, let's try the greenish background or shadow, have some (printer) icons in the background as kind of watermarks, or just a lighter blue frame.
Blue rectangle is set in SwPagePreviewLayout::PaintSelectMarkAtPage() at sw/source/core/view/pagepreviewlayout.cxx to COL_LIGHTBLUE.
Shadow is done in sw/source/core/layout/paintfrm.cxx: SwPageFrame::PaintBorderAndShadow() ... aShadowColor = SwViewOption::GetShadowColor();
Hi. I'd like to work on this. I tried to make the border light gray. It does look better than any shade of blue. Here: https://imgur.com/a/pTiS61e If you could give me the RGB, I could define a new COL_LIGHTERBLUE in include/tools/color.hxx Here's a few I've tried: i. 141, 203, 214 ii. 162, 219, 213 iii. 171, 196, 219 Also, could you point me to the code to generate watermarks? Thanks.
(In reply to Abhinav from comment #6) > ... Here: https://imgur.com/a/pTiS61e Please use two pages so one can see one page without and another with the colored rectangle. > If you could give me the RGB, I could define a new COL_LIGHTERBLUE in > include/tools/color.hxx Wouldn't use this central definition for a color that is used in only one place. Just aColor(141, 203, 214) is fine, IMHO. > Here's a few I've tried: > > i. 141, 203, 214 > ii. 162, 219, 213 > iii. 171, 196, 219 I leave this to Rizal. > Also, could you point me to the code to generate watermarks? Thanks. Well, that was an idea for a completely different look and feel. You would have to find the paint method and add your stuff there. However, the rectangle is used to indicate the selected page (for what reason ever) and the watermark is something similar to the greenish background from WPS for just design purpose.
Please don't use kind of watermarks or page background to visualize an active page because this could be misunderstood as part of the page itself and not of the print preview.
(In reply to Abhinav from comment #6) > Here's a few I've tried: > > i. 141, 203, 214 > ii. 162, 219, 213 > iii. 171, 196, 219 Could you please produce screenshot of each color and share to me?
(In reply to Rizal Muttaqin from comment #9) > (In reply to Abhinav from comment #6) > > > Here's a few I've tried: > > > > i. 141, 203, 214 > > ii. 162, 219, 213 > > iii. 171, 196, 219 > > Could you please produce screenshot of each color and share to me? Here: https://imgur.com/a/pTiS61e I updated the album. I'd like to hear if you have any suggestions regarding the colors. Also, I think the border shadow looks a bit weird with the lighter colors, so maybe we can do something about it.
(In reply to Abhinav from comment #10) > Here: https://imgur.com/a/pTiS61e > > I updated the album. > > I'd like to hear if you have any suggestions regarding the colors. Also, I > think the border shadow looks a bit weird with the lighter colors, so maybe > we can do something about it. Great, I prefer (20, 40, 51) the most pleasant choice and then (117, 114, 106). The rest looks equivocal and hard to see. and now after two minutes I prefer (117, 114, 106) hahaha.
(In reply to Rizal Muttaqin from comment #11) > Great, I prefer (20, 40, 51) the most pleasant choice and then (117, 114, > 106). The rest looks equivocal and hard to see. > > and now after two minutes I prefer (117, 114, 106) hahaha. So, should we go with (117, 114, 106)?
(In reply to Abhinav from comment #12) > (In reply to Rizal Muttaqin from comment #11) > > > Great, I prefer (20, 40, 51) the most pleasant choice and then (117, 114, > > 106). The rest looks equivocal and hard to see. > > > > and now after two minutes I prefer (117, 114, 106) hahaha. > > So, should we go with (117, 114, 106)? Yes please
This bug assigned for two months without any further update
(In reply to Heiko Tietze from comment #7) > Please use two pages so one can see one page without and another with the > colored rectangle. > > > If you could give me the RGB, I could define a new COL_LIGHTERBLUE in > > include/tools/color.hxx > > Wouldn't use this central definition for a color that is used in only one > place. Just aColor(141, 203, 214) is fine, IMHO. > Where we can define the new color : aColor(117, 114, 106)?
(In reply to Rizal Muttaqin from comment #15) > Where we can define the new color : aColor(117, 114, 106)? https://opengrok.libreoffice.org/xref/core/sw/source/core/layout/paintfrm.cxx?r=d4248915#5840 if you follow the breadcumb you find the default in https://opengrok.libreoffice.org/xref/core/vcl/source/app/settings.cxx?r=c275184a#652 maShadowColor = COL_GRAY; So this one is not the blue frame but somewhere in the mentioned function you find it. And I strongly recommend to not change the settings default as those colors likely are used at different places. If needed we could introduce an expert option.
(In reply to Heiko Tietze from comment #16) > (In reply to Rizal Muttaqin from comment #15) > > Where we can define the new color : aColor(117, 114, 106)? > > https://opengrok.libreoffice.org/xref/core/sw/source/core/layout/paintfrm. > cxx?r=d4248915#5840 > if you follow the breadcumb you find the default in > https://opengrok.libreoffice.org/xref/core/vcl/source/app/settings. > cxx?r=c275184a#652 > maShadowColor = COL_GRAY; > > So this one is not the blue frame but somewhere in the mentioned function > you find it. And I strongly recommend to not change the settings default as > those colors likely are used at different places. If needed we could > introduce an expert option. I'm not pretty sure about this patch https://gerrit.libreoffice.org/c/core/+/93521
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f3a4869ca3e617221020a0b8fe5fa0f41ec66aa5 tdf#129235 Change the color of active page border in Print Preview It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 160801 [details] solved nice! See screenshot Verified in Version: 7.0.0.0.alpha1+ Build ID: 47c81498c63ae71a351f43ec2f073ba92d99fc1d CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-05-13_06:53:25 Calc: threaded