Description: Impress on iOS (app version 4.2) has a button in the menu that shows a set of templates in the sidebar. However it is not possible to apply one of the give templates to the current slide deck. Steps to Reproduce: 1. Create/open a slide deck using the iOS app (version 4.2) 2. Tap on the button that opens the sidebar with the templates 3. Try to apply one of the templates/design to the current slide deck Actual Results: I can't find a way to apply a style/template to the current slide deck. Expected Results: It should be obvious how a given style/template can be applied. Reproducible: Always User Profile Reset: No Additional Info: Tested using 4.2 (25) on iOS 13.3.x
Created attachment 156568 [details] Printscreen showing the issue
Moving to NEW
Looking at this now.
In web-based Online, it seems that only the master slide used in the presentation document is visible in the "Available for Use" list in the sidebar. That is even less useful...
Note to self: It is the IMPL_LINK_NOARG(MasterPagesSelector, ClickHandler, ValueSet*, void) in sd/source/ui/sidebar/MasterPagesSelector.cxx that is invoked when one clicks/taps on one of the master pages in the sidebar.
In MasterPagesSelector::AssignMasterPageToSelectedSlides(), the problem seems to be that the SlideSorterViewShell::GetSlideSorter(mrBase) call returns NULL.
I strongly suspect that there is no "slide sorter" (in the core LO sense) in Online, and thus the code can not work even in theory. It would be a significant amount of feature work to change this. Probably the best is to just remove that "Available for Use" section in the Online (and mobile app) case.
Mostly note to self: Argh, it is weirdly hard to get rid of the "Available for Use" section in the sidebar. I tried to simply return early in DrawViewShell::FuTemporary() in the case of comphelper::LibreOfficeKit::isActive() && nSId == SID_MASTER_SLIDES_PANEL , but then the sidebar does not show up at all, huh...
Suggested (surprisingly simple) fix in https://gerrit.libreoffice.org/c/core/+/87131 .
Suggested fix causes a unit test failure though; investigating.
Fix is now in the cp-6.2 branch. But note that it only is possible to apply a template (i.e. master slide) to the single selected slide. Or is there a way to select multiple slides in the pane on the left?
Just for the records: the issue is still present in 4.2 (31). (I was not sure, if "Fix is now in the cp-6.2 branch" means that it's also part of the latest iOS build so I tested it and just wanted to have this written down before I test again).
The recent 4.2(32) build contains the fix.
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b80445bce9ef9d145bb239b60b3f57ebc9f40a26 tdf#129388: Do as kendy suggested in 7e291eedbad335bf8bbc8a17cc3d633bf66d0e90 It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This issue has been fixed and can be closed. Tested with 4.2 (32). Thanks a lot to the Collabora team and especially to Tor for fixing this!
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ecfc94359d701d03b59812c30f5a77556891e0d4 tdf#129388: Avoid any actual painting of the slide sorter in the LOKit case It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.