Bug 129537 - KeyID gogLP is assigned to two strings
Summary: KeyID gogLP is assigned to two strings
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.beta1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-21 09:12 UTC by So
Modified: 2020-06-07 15:33 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description So 2019-12-21 09:12:49 UTC
There are two strings "None" with the same key-ID in Weblate.
Comment 2 Julien Nabet 2020-01-10 12:53:41 UTC
I can only confirm the bug.
Now I don't know how key ids are generated.
Comment 3 Aron Budea 2020-06-06 07:14:29 UTC
So as I understand the clash is between these two:
<property name="label" translatable="yes" context="colorwindow|none_color_button">None</property>
https://opengrok.libreoffice.org/xref/core/svtools/uiconfig/ui/linewindow.ui?r=8e2bd8fb#17
<property name="label" translatable="yes" context="colorwindow|none_color_button">None</property>
https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/colorwindow.ui?r=6e6fdb62#57

Caolán, would changing the context from colorwindow to linewindow solve this clash?
Comment 4 Julien Nabet 2020-06-06 08:59:53 UTC
(In reply to Aron Budea from comment #3)
> ...
> Caolán, would changing the context from colorwindow to linewindow solve this
> clash?

Caolán will know better than me but IMHO I think you're right so you should submit a patch.
Comment 5 Caolán McNamara 2020-06-06 14:52:05 UTC
I imagine comment #3 is the right thing to do.
Comment 6 Commit Notification 2020-06-06 15:40:30 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/486c946aa0e489580b78b2934259fe24696057c0

tdf#129537 duplicate context in two different modules

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-06-06 15:57:30 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/ff4fe7e9183ed3811a4674c95c58fa8690f360dc

tdf#129537 duplicate context in two different modules

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Caolán McNamara 2020-06-06 16:09:42 UTC
I don't know if we should fix it in 6-4 seeing as presumably that disrupts existing translations and I presume its not significant enough to require doing that.
Comment 9 sophie 2020-06-06 19:20:16 UTC
(In reply to Caolán McNamara from comment #8)
> I don't know if we should fix it in 6-4 seeing as presumably that disrupts
> existing translations and I presume its not significant enough to require
> doing that.

Agreed, no need to have it in 6-4 and thanks for fixing it.
Comment 10 Ming Hua 2020-06-06 23:37:28 UTC
(In reply to Commit Notification from comment #6)
> Caolán McNamara committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/486c946aa0e489580b78b2934259fe24696057c0
> 
> tdf#129537 duplicate context in two different modules
> 
> It will be available in 7.1.0.

-            <property name="label" translatable="yes" context="colorwindow|none_color_button">None</property>
+            <property name="label" translatable="yes" context="linewindow|none_color_button">None</property>

In the spirit of providing correct context for translators, instead of just avoiding KeyID clash, shouldn't the context be "linewindow|none_line_button"?
Comment 11 Caolán McNamara 2020-06-07 14:15:47 UTC
we can do that
Comment 12 Commit Notification 2020-06-07 15:33:19 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2d15e6808a217aea9ac7c56e0c4c8ef2dc58ec94

tdf#129537 call it none_line_button not none_color_button

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2020-06-07 15:33:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/09b70f8d846d718b73eaaf80c368a8a5cc9f9596

tdf#129537 call it none_line_button not none_color_button

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.