Bug 129726 - The help button (and F1 for individual items) in the "Edit Index Entry" dialog opens the help for "Insert Index Entry"
Summary: The help button (and F1 for individual items) in the "Edit Index Entry" dialo...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.3.2 release
Hardware: All All
: medium normal
Assignee: Olivier Hallot
URL:
Whiteboard: target:6.5.0 target:6.4.0.2 target:7.6.0
Keywords:
Depends on:
Blocks: Help-Link
  Show dependency treegraph
 
Reported: 2020-01-01 23:03 UTC by sdc.blanco
Modified: 2023-04-29 14:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-01-01 23:03:11 UTC
To see the problem:

1.  insert an index entry  (Insert > Table of Contents and Index > Table of Contents, Index, or Bibliography - Index Entry

2.  edit this entry  (right-click with cursor in index entry, choose "Index Entry...")

3.  Click on "Help" Button, 
4.  Place cursor in different fields, check boxes and press F1

Actual result (for both Help button and F1):  https://help.libreoffice.org/6.5/en-US/text/swriter/01/04120100.html

Expected result:  https://help.libreoffice.org/6.5/en-US/text/swriter/01/02160000.html
Comment 1 sdc.blanco 2020-01-01 23:05:50 UTC
Also tested with:

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 444f0d256957544d26b9af9a0898364e829df1b5
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: sv-SE (en_DK); UI-Language: en-US
Calc: threaded
Comment 2 Julien Nabet 2020-01-02 08:24:15 UTC
Olivier: thought you might be interested in this one.
Comment 3 Commit Notification 2020-01-02 14:25:12 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/52b29ea4c9f46921d2d7e156dc3532a15800a131

tdf#129726 Wrong bookmark for Edit Index Entry
Comment 4 Commit Notification 2020-01-02 14:32:33 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/help/commit/b69d4fce04ce452840f9c4fbe0de83e7316b5900

tdf#129726 Wrong bookmark for Edit Index Entry
Comment 5 Dieter 2020-03-30 14:18:30 UTC
Verified with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 1c9ced04189c9d23ffea05d5570960b54b05ef28
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: CL
Comment 6 Stéphane Guillou (stragu) 2023-01-09 14:32:02 UTC
Reopening, as both Insert and Edit dialog still both use the same HID and point to the Insert help page. Checked in a master build from today:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Related to this, there is bug 131711.
Caolán, you implemented the switch in https://gerrit.libreoffice.org/c/core/+/91498, could please check?
Comment 7 Olivier Hallot 2023-01-10 12:36:40 UTC
The 2 commands (insert and edit index entry) use the same dialog and Help contents of the same page are almost identical.

I'm merging the 2 Help pages into one and adjust text for each command.
Comment 8 Caolán McNamara 2023-01-10 12:54:32 UTC
it works wonderfully in the off-line help where we can check if an exact page exists and search for something good, on the on-line case (which I bet this is) then that can't work
Comment 9 Caolán McNamara 2023-01-10 12:57:58 UTC
If Olivier is going to change the help, then I won't attempt any additional hacks for this and maybe afterwards we can revert

commit 4d25be13b6d2f4d1a83efa224cc02e92f20bef11
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Wed Apr 1 16:17:00 2020 +0100

    tdf#131711 there are two help pages for the index dialog which has two modes
Comment 10 Olivier Hallot 2023-01-10 14:23:55 UTC
Agree we can eventually revert later

commit 4d25be13b6d2f4d1a83efa224cc02e92f20bef11
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Wed Apr 1 16:17:00 2020 +0100

Also fixes issue of missing "Help ID: modules/swriter/ui/indexentry/dialog-action_area1" entry.

Patch submitted 
https://gerrit.libreoffice.org/c/help/+/145269
Comment 11 Commit Notification 2023-01-12 10:55:27 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ce58da3240e508800bd3e6fd7d56fb5fbde3349d

tdf#129726 Add extended tips to Index Entry dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-01-12 10:56:30 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/6b6ed464e1709685a0c20a7254d169c5553aa13a

tdf#129726 Insert Index and Edit Index Help pages
Comment 13 Commit Notification 2023-04-04 11:11:22 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/250b820a24640a33d73a6e690e04e36be01cda28

tdf#129726  make extended tips visible for 1st and 2nd key

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 sdc.blanco 2023-04-07 13:37:23 UTC
@Stephane - maybe this ticket is fixed again?
When I use Help or press F1, I get relevant (online) help.
Comment 15 Stéphane Guillou (stragu) 2023-04-08 10:08:35 UTC
Yes, thanks Seth and Caolán and Olivier. Pointing to the same help page with all the necessary info in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 23bd3bd10e74b0c23c2654d02d7d830e7693adac
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 16 Dieter 2023-04-29 14:32:03 UTC
(In reply to Stéphane Guillou (stragu) from comment #15)
> Yes, thanks Seth and Caolán and Olivier. 

=> VERIFIED FIXED