Bug 129738 - Tests from SwLayoutWriter fail in screen resolution 125% but work in 100%
Summary: Tests from SwLayoutWriter fail in screen resolution 125% but work in 100%
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-02 12:36 UTC by Regina Henschel
Modified: 2020-03-18 15:51 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-01-02 12:36:33 UTC
I have set my screen resolution to 125% in Windows 10. That is 120dpi. 100% is 96dpi. Screen resolutions above 125dpi will trigger some high resolution settings, but 120dpi is below that limit.

When I build "make sw.check" the tests testTdf125300, testTdf115630 and testTdf129054 fail. The tests do not fail in 100% screen resolution.

Expected: The tests work in 120dpi too.
Comment 1 Julien Nabet 2020-01-02 13:21:17 UTC
Mike: noticing https://cgit.freedesktop.org/libreoffice/core/commit/?id=386771e25d35f846c16f9ba7ddbf135c3cba3565, thought you might have some idea for this one?
Comment 2 Mike Kaganski 2020-01-02 13:30:38 UTC
(In reply to Regina Henschel from comment #0)
> the tests testTdf125300, testTdf115630 and testTdf129054 fail

They all are "handled" in my https://gerrit.libreoffice.org/c/core/+/85974 (which, along with https://gerrit.libreoffice.org/c/core/+/85967, waits for review from NISZ LibreOffice team which had created all these tests). The "fix" is almost guaranteed to be wrong, since several introduced tolerances are so large that the test seems to make no sense with them. Only test authors could create better tests.

The problems are:
1. Lack of testing with non-default resolution (both automated on buildbots, and by test authors);
2. Some processing in core that takes screen resolution into account. IMO, each and every such place in code, which is not at the moment of actual output to screen, is a bug.
Comment 3 László Németh 2020-01-06 09:41:04 UTC
@all Mike's patch is there in the master. The unit tests are still valid with the enlarged tolerances. Thanks for your help and fix!