Created attachment 156927 [details] dialog invoked by Set Background Image in Draw 1. In Draw, choose Page - Set Background Image. 2. The opened dialog has title "Set Background Image for Slide ...", which is not proper for Draw. The title could be simply "Set Background Image" (the dots are also redundant). Observed in 6.3.3.2 and in master: Version: 6.5.0.0.alpha0+ Build ID: ffe9ff2cf63112ac04a695740a5637f25c16abe8 But it is possible that this is an older issue.
Thank you for reporting the bug. I can reproduce this in Version: 6.4.0.0.alpha1+ (x86) Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
Thank you for reporting the bug. I can also reproduce this in a recent master build on Linux. Version: 6.5.0.0.alpha0+ Build ID: 8930a7d8b8e649336300d98f0a1f27114ad392ea CPU threads: 1; OS: Linux 5.0; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master Locale: es-ES (en_US.UTF-8); UI-Language: en-US Calc: threaded
Also reproducible in Version: 5.2.0.0.alpha0+ Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 Threads 4; Ver: 4.19; Render: default;
@Muhammet, @Heiko, this issue looks like a good candidate for an easyhack. What do you think? would you mind providing the code pointer ?
(In reply to Xisco Faulí from comment #4) > @Muhammet, @Heiko, this issue looks like a good candidate for an easyhack. > What do you think? would you mind providing the code pointer ? @Xisco, Nice catch! :) Just invoke 'git grep "Set Background Image for"' on terminal inside the cloned/local core repo/dir, to find the location of the title string. You will find something like this: #define STR_SOMETHING NC_("STR_SOMETHING", "Set Background Image for Slide ..." ) Then invoke 'git grep STR_SOMETHING' to find the locations where this string is used, and check to make sure it is not used somewhere else not-suitable for its new form ("Set Background Image"). Then replace "Set Background Image for Slide ..." you found earlier with "Set Background Image", and test to see it in action, and submit the patch.
I believe the string is used in Impress and Draw, thus, the fix should look similar to https://cgit.freedesktop.org/libreoffice/core/commit/?id=5bc12e114fec50274580005647345a5392741ded
It's STR_SET_BACKGROUND_PICTURE used in sd/source/ui/func/fupage.cxx only.
(In reply to Heiko Tietze from comment #7) > It's STR_SET_BACKGROUND_PICTURE used in sd/source/ui/func/fupage.cxx only. ah, ok, I didn't check. Then I change my comment to obsolete
Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0970b8b652835001076d14138a54b4add1b93a93 tdf#129786 give correct title for Draw dialog box It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.