Description: https://openqa.opensuse.org/tests/1135498#step/ooffice/8 The Qt UI swapped the button order in the save dialog, which is counter the UI guidelines in Qt. Steps to Reproduce: Install the KDE interface for libreoffice and try to save the dialog. Actual Results: The dialog buttons compared to 6.3 are swapped. Expected Results: No buttons movement should happen. Reproducible: Always User Profile Reset: No Additional Info:
Created attachment 156998 [details] old save dialog
Created attachment 156999 [details] new save dialog
There seems to be a mismatch between what Application::GetDesktopEnvironment() returns and what getButtonPriority() in layout.cxx expects. This should fix it: diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index 981ac62..9c5a363 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -718,8 +718,8 @@ static int getButtonPriority(const OString &rType) const OUString &rEnv = Application::GetDesktopEnvironment(); if (rEnv.equalsIgnoreAsciiCase("windows") || - rEnv.equalsIgnoreAsciiCase("tde") || - rEnv.startsWithIgnoreAsciiCase("kde")) + rEnv.equalsIgnoreAsciiCase("lxqt") || + rEnv.startsWithIgnoreAsciiCase("plasma")) { pOrder = &aSaveDiscardCancel[0]; } LXQt uses Save/Discard/Cancel as well, so I added that and removed tde, which is not returned anymore.
Submitted to 6.4 branch and master.
Tomáš Chvátal committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4f0d4c9387eb1d73f96b9072128cff2038f6c61a tdf#129879 Fix wrong order of buttons It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tomáš Chvátal committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/95d7d13205c05c2114a6d3bc2c4538246b22f3e0 tdf#129879 Fix wrong order of buttons It will be available in 6.4.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.