Bug 129948 - Alt+R is double assigned in French UI (Find toolbar and main menu)
Summary: Alt+R is double assigned in French UI (Find toolbar and main menu)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
6.4.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-12 02:20 UTC by TorrAB
Modified: 2020-10-24 15:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshots of "Find and Replace..." dialog and "Find..." toolbar with French UI (74.54 KB, image/png)
2020-10-19 05:35 UTC, Ming Hua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2020-01-12 02:20:44 UTC
Description:
Writer: ouvrir la barre Rechercher, presser ‘r’ pour ‘Respecter la casse’, mais cela ouvre le menu Formulaire


Steps to Reproduce:
1.Writer: ouvrir la barre Rechercher, presser ‘r’ pour ‘Respecter la casse’.

2.
3.

Actual Results:
ouvre le menu Formulaire


Expected Results:
activer ‘Respecter la casse’.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Julien Nabet 2020-01-12 14:37:33 UTC
On pc Debian x86-64 with master sources updated today + French locale, I don't reproduce this, typing "r" doesn't open Forms menu, just put "r" in Search box.

(I launched Writer then Ctrl-H to make the dialog search/replace appear)
Comment 2 TorrAB 2020-01-13 02:30:34 UTC
(In reply to Julien Nabet from comment #1)
> On pc Debian x86-64 with master sources updated today + French locale, I
> don't reproduce this, typing "r" doesn't open Forms menu, just put "r" in
> Search box.
> 
> (I launched Writer then Ctrl-H to make the dialog search/replace appear)

Sorry! Hit ‘~r’ (alt-r) instead.
Comment 3 Dieter 2020-04-14 15:36:10 UTC
Same behaviour in English UI: I've opened Find toolbar, and pressed ALT+r => Form menu opened.

If you open Find & Replace Dialog ALT+r marks "Diacritic-sensitive" option in English UI. In German UI nothing happens (that is expected).

TorrAB please explain, why you expect something different. Or is you report about Find&Replace dialog?

=> NEEDINFO
Comment 4 Julien Nabet 2020-04-16 09:08:41 UTC
I still don't reproduce this with Ctrl-R with French or English UI and with gen or gtk3 rendering.
uncc myself since I can't help here.
Comment 5 QA Administrators 2020-10-14 04:31:12 UTC Comment hidden (obsolete)
Comment 6 TorrAB 2020-10-16 01:41:48 UTC
The bug no longer exists because ‘R’ is no longer underlined in ‘Respecter la casse’. ~r opens Formulaire, as expected.
But this shortcut could be restored by activating (and underlining) ‘p’ instead of ‘R’ in ‘Respecter la casse’.
Comment 7 Ming Hua 2020-10-16 02:47:17 UTC
The "Match case" checkbox in the Edit > Find and Replace... dialog (hope this is what TorrAB is referring to, I don't speak French and find the previous discussion a bit convoluted) is the following string, KeyID 75TZD:
https://weblate.documentfoundation.org/translate/libo_ui-master/svxmessages/fr/?checksum=ab428eb692c8accd

So according to Weblate the translation for this string hasn't changed since 6.4, and has always been translated to "Respecter la _casse", which means in French UI Alt+C is the keyboard shortcut (also the c in casse should be underlined in French UI).

Or are we talking about a different string elsewhere?
Comment 8 Dieter 2020-10-16 09:17:08 UTC
(In reply to TorrAB from comment #6)
> The bug no longer exists because ‘R’ is no longer underlined in ‘Respecter
> la casse’. ~r opens Formulaire, as expected.

Can this bug be closed then
Comment 9 TorrAB 2020-10-17 12:58:20 UTC
(In reply to Ming Hua from comment #7)
> The "Match case" checkbox in the Edit > Find and Replace... dialog (hope
> this is what TorrAB is referring to

yes, it is.

> in French UI Alt+C is the keyboard shortcut (also the c in casse should be
> underlined in French UI

The c is not underlined and Alt+C does not work, in version 7.0.1.2(x64)
Comment 10 Ming Hua 2020-10-19 05:35:21 UTC
Created attachment 166486 [details]
Screenshots of "Find and Replace..." dialog and "Find..." toolbar with French UI

OK, so I switched to French UI and had a look myself.

(In reply to TorrAB from comment #9)
> (In reply to Ming Hua from comment #7)
> > The "Match case" checkbox in the Edit > Find and Replace... dialog (hope
> > this is what TorrAB is referring to
> 
> yes, it is.
> 
> > in French UI Alt+C is the keyboard shortcut (also the c in casse should be
> > underlined in French UI
> 
> The c is not underlined and Alt+C does not work, in version 7.0.1.2(x64)
Apparently there is some misunderstanding here (due to language barrier?), as seen in the attached screenshots, the "Find and Replace..." dialog (Ctrl+H) has an underlined c and Alt+C accelerator works as expected.

On the other hand, the "Find..." toolbar (Ctrl+F) has a "Respecter la casse" checkbox with no underlined character and no keyboard accelerator.  Perhaps this is what TorrAB was talking about?

The screenshots are made with 7.0.2 (information is from English UI, not French):
Version: 7.0.2.2 (x64)
Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994
CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: en-US
Calc: threaded
Comment 11 TorrAB 2020-10-21 00:54:49 UTC
> the "Find and Replace..." dialog (Ctrl+H) has an underlined c and Alt+C accelerator works as expected.

* c is underlined, but it does not work. Alt+c puts dots around "Respecter la _casse" but does not put a check-mark in the box and has no effect. One must click the box.
* In the English version, the shortcut is ~t (for Ma_tch case), and it works.
> 
> On the other hand, the "Find..." toolbar (Ctrl+F) has a "Respecter la casse"
> checkbox with no underlined character and no keyboard accelerator.  Perhaps
> this is what TorrAB was talking about?
* yes. There is no shortcut in either language.
Comment 12 Ming Hua 2020-10-21 05:22:47 UTC
(In reply to TorrAB from comment #11)
> > the "Find and Replace..." dialog (Ctrl+H) has an underlined c and Alt+C accelerator works as expected.
> 
> * c is underlined, but it does not work. Alt+c puts dots around "Respecter
> la _casse" but does not put a check-mark in the box and has no effect. One
> must click the box.
That's because there are multiple UI items with accelerator Alt+C.  If you want to avoid mouse clicks, press space key after Alt+C, and the box will be selected (press space key again to deselect it).

> * In the English version, the shortcut is ~t (for Ma_tch case), and it works.
It works for English UI because there is only one item with Alt+T accelerator.

Anyway, this is off-topic for this bug.  If you don't like the way accelerators are assigned currently for this dialog, please file a seperate bug.

> > On the other hand, the "Find..." toolbar (Ctrl+F) has a "Respecter la casse"
> > checkbox with no underlined character and no keyboard accelerator.  Perhaps
> > this is what TorrAB was talking about?
> * yes. There is no shortcut in either language.
And in older versions (I checked 6.2.8), even there is underlined letter (for English UI it's M, i.e. "_Match case"), accelerator (Alt+M for English) doesn't work.

So can we close this bug now?  To make accerlerators work for this toolbar is beyond the scope of localization and should also be filed as separate bugs (and I suspect such a bug already exists).
Comment 13 TorrAB 2020-10-24 00:33:43 UTC
> > * c is underlined, but it does not work. Alt+c puts dots around "Respecter la _casse" but does not put a check-mark in the box and has no effect.
> That's because there are multiple UI items with accelerator Alt+C.

**	The shortcut keys could be chosen to avoid conflicts, eg ‘Tout _rechercher’, ‘Rec_hercher le précédent’, ‘C_ommentaires’, 

> > * In the English version, the shortcut is ~t (for Ma_tch case), and it works.
> It works for English UI because there is only one item with Alt+T
> accelerator.
**see above
> So can we close this bug now?  To make accerlerators work for this toolbar
> is beyond the scope of localization and should also be filed as separate
> bugs (and I suspect such a bug already exists).
**OK
Comment 14 Ming Hua 2020-10-24 15:14:25 UTC
Alright, let's close this bug as WORKSFORME.

TorrAB, I acknowledge that there are two additional UI problems:

(1) The keyboard accelerator Alt+C is used for multiple UI items in the Find and Replace dialog (Ctrl+H), and it would be nice to have them use separate ones.  This is a l10n issue, and should be solved by French translators.

(2) There is no accelerator for the "Match case" checkbox in the Find toolbar (Ctrl+F) ("Respecter la casse" for French).  This is for all languages and should be solved by developers.

Please file separate bugs if you want further discussions on either of these two issues.