Bug 130001 - It doesn't open DOCX file
Summary: It doesn't open DOCX file
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: DOCX-Opening
  Show dependency treegraph
Reported: 2020-01-14 16:54 UTC by Roman Kuznetsov
Modified: 2020-08-16 15:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Problem DOCX (375.79 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-01-14 16:55 UTC, Roman Kuznetsov
Flamegraph (338.98 KB, application/x-bzip)
2020-01-17 20:31 UTC, Julien Nabet

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2020-01-14 16:54:09 UTC
It doesn't open DOCX file from attach

Steps to Reproduce:
1. Try open DOCX file from attach
2. LO hangs

Actual Results:
LO hangs

Expected Results:
LO opens file fine

Reproducible: Always

User Profile Reset: No

Additional Info:
ID сборки: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL; 
Локаль: ru-RU (ru_RU); Calc: CL

but LO opens file in version

Version: (x64)
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: ru-RU (ru_RU); Calc: CL

so it's a regression
Comment 1 Roman Kuznetsov 2020-01-14 16:55:08 UTC
Created attachment 157150 [details]
Problem DOCX
Comment 2 raal 2020-01-14 17:22:12 UTC
Confirm with Version: (x64)
Build ID: d122a9d12d970d55f4dc9e4268e0681fd2e6786f
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win;
I can open the file in MSWord2010
Comment 3 Julien Nabet 2020-01-14 21:17:48 UTC
On pc Debian x86-64 with master sources updated today, I don't reproduce this.
It takes a bit of time however.
Comment 4 raal 2020-01-15 14:27:47 UTC
This seems to have begun at the below commit.
Adding Cc: to Mike Kaganski ; Could you possibly take a look at this one? Thanks
 fdce4bf9f5cc6b285970304aa77ad4a55cff5ab3 is the first bad commit
commit fdce4bf9f5cc6b285970304aa77ad4a55cff5ab3
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Oct 16 11:03:23 2018 -0700

    source 5d0c83fd4cf91083805f60f49e4fafd3d6ac73d4

author	Mike Kaganski <mike.kaganski@collabora.com>	2018-10-16 18:00:45 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2018-10-16 19:53:32 +0200
commit 5d0c83fd4cf91083805f60f49e4fafd3d6ac73d4 (patch)
tree 98fc6da2e4507d2de93da9c2d848b9c23feb76de
parent c8b68f7d63df9335ab4ef90441d3d2815bb4ddd6 (diff)
tdf#119885: OOXML import: try to get cell paddings as Word does
Comment 5 Mike Kaganski 2020-01-16 11:53:59 UTC
(In reply to raal from comment #4)

... and later the hang was fixed in https://git.libreoffice.org/core/+/b7d4418c309c8bc4fd25485dd3a0ea6ad9edf34e, though it still is slow - perf regression. Possibly Noel would be interested?
Comment 6 Xisco Faulí 2020-01-17 13:32:37 UTC
@Julien, would you mind getting a perf chart from the file attached ?
Comment 7 Xisco Faulí 2020-01-17 13:37:47 UTC
it takes 

real	0m25,374s
user	0m22,981s
sys	0m1,056s


Build ID: cc36c115004cb75037b0e4fdadff09035f765cd5
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

which is pretty decent time.

Roman, a few questions:
1. Do you reproduce it in master?
2. Do you reproduce it on Linux? Otherwise, win only ?
3. Could you please check how long it takes for you ?
Comment 8 Julien Nabet 2020-01-17 20:31:43 UTC
Created attachment 157236 [details]

Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today.
Comment 9 QA Administrators 2020-07-16 03:44:41 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2020-08-16 04:28:59 UTC Comment hidden (obsolete)
Comment 11 Roman Kuznetsov 2020-08-16 15:28:58 UTC
heh, LO 7.1 alpha 0 opens it so fast

Version: (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

so let's change status to WFM