Bug 130035 - Sidebar widget to choose an arrow style is too wide
Summary: Sidebar widget to choose an arrow style is too wide
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-16 13:45 UTC by andreas_k
Modified: 2020-01-23 22:09 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
width request (344.34 KB, image/png)
2020-01-16 21:36 UTC, andreas_k
Details
width request with qt backend (338.64 KB, image/png)
2020-01-16 21:39 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2020-01-16 13:45:58 UTC
GtkComboBox didn't respect wdith_request see sidebarline.ui
Comment 1 Caolán McNamara 2020-01-16 14:40:20 UTC
There isn't enough information here to know what you mean
Comment 2 andreas_k 2020-01-16 21:36:18 UTC
Created attachment 157202 [details]
width request

Hope it's now easier to understand
Comment 3 andreas_k 2020-01-16 21:39:59 UTC
Created attachment 157203 [details]
width request with qt backend

in qt the width_request was used
Comment 4 Caolán McNamara 2020-01-20 17:33:40 UTC
I think here its because gtk won't allow a size request less than its minimum size. If you were to in code call widget->set_size_request(65, -1) then we explicitly ellipsize the cell contents of the combobo widget to try to get it to shrink down past its natural size which is ok for the general case, but this case I think has an image in the combobox so that wouldn't work.

IIRC there is another control which lists *just* the arrow heads and not their names. If we're trying to shrink things to fit then changing over to that control might give the better results.
Comment 5 andreas_k 2020-01-20 20:46:00 UTC
(In reply to Caolán McNamara from comment #4)
> IIRC there is another control which lists *just* the arrow heads and not
> their names. If we're trying to shrink things to fit then changing over to
> that control might give the better results.

That would be the best in addition that we don't have trouble with the size, the name of an arrow is not that important, it's the arrow shape to recognize and not the label.
Comment 6 Caolán McNamara 2020-01-21 08:56:33 UTC
let me take this issue then and I'll track down that control
Comment 7 Commit Notification 2020-01-21 11:41:35 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f311d5b778eede2642a49108a08d4134ad1ce097

Related: tdf#130035 weld SvxLineEndWindow

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-01-21 12:56:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/08e633d777f1d2cf11a93ccb55f231d084f3220c

Related: tdf#130035 let SvxLineEndWindow have a menubutton parent

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2020-01-21 14:37:24 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/af71531ea292c62f785f8300205eddea8c2d33d2

Resolves: tdf#130035 reuse toolbar for arrow styles in sidebar

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2020-01-21 20:07:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6e249594f27c75b9b785da4e17b79a10d3b5265f

Revert "Related: tdf#130035 let SvxLineEndWindow have a menubutton parent"

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 andreas_k 2020-01-23 22:09:59 UTC
Thanks Caolan now it work better.