Bug 130109 - Undo requires three iterations (<Ctrl>-<Z>) instead of just one
Summary: Undo requires three iterations (<Ctrl>-<Z>) instead of just one
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo PPTX
  Show dependency treegraph
 
Reported: 2020-01-21 12:39 UTC by Gerald Pfeifer
Modified: 2024-10-19 10:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document (34.15 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-01-21 12:39 UTC, Gerald Pfeifer
Details
Step 0 - original view (18.29 KB, image/png)
2020-01-21 12:40 UTC, Gerald Pfeifer
Details
Step 1 - right align (17.27 KB, image/png)
2020-01-21 12:41 UTC, Gerald Pfeifer
Details
Step 3 - second item incorrect (17.56 KB, image/png)
2020-01-21 12:41 UTC, Gerald Pfeifer
Details
Step 4 - first item incorrect (17.49 KB, image/png)
2020-01-21 12:42 UTC, Gerald Pfeifer
Details
Step 5 - everything centered? (17.35 KB, image/png)
2020-01-21 12:43 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2020-01-21 12:39:54 UTC
Created attachment 157302 [details]
Sample document

How to reproduce:

 0. Open sample document (okay).
 1. Right align list in the right object (okay).
 2. Undo via <Ctrl>-<Z> (bug - nothing happens)
 3. Undo via <Ctrl>-<Z> (bug - second list item is misformatted)
 4. Undo via <Ctrl>-<Z> (bug - first list item is misformatted)
 5. Undo via <Ctrl>-<Z> (bug - everything is centered out of a sudden?)

Funny enough, once I click outside the shape and hit <Ctrl>-<Z> another
time, it reverts to the original state.  Still very unexpected behavior.
Comment 1 Gerald Pfeifer 2020-01-21 12:40:38 UTC
Created attachment 157303 [details]
Step 0 - original view
Comment 2 Gerald Pfeifer 2020-01-21 12:41:09 UTC
Created attachment 157304 [details]
Step 1 - right align
Comment 3 Gerald Pfeifer 2020-01-21 12:41:46 UTC
Created attachment 157305 [details]
Step 3 - second item incorrect
Comment 4 Gerald Pfeifer 2020-01-21 12:42:21 UTC
Created attachment 157306 [details]
Step 4 - first item incorrect
Comment 5 Gerald Pfeifer 2020-01-21 12:43:07 UTC
Created attachment 157307 [details]
Step 5 - everything centered?
Comment 6 Gerald Pfeifer 2020-01-21 12:46:19 UTC
To summarize, it's one issue ("undo not reverting to the previous state")
which manifests manifold:

 - undo takes several steps instead of one,
 - undo loses bullet points (as does redo applied after the undo)
 - the last undo out of a sudden centers text unexplicably
Comment 7 Durgapriyanka 2020-01-21 15:35:17 UTC
Thank you for reporting the bug. I can reproduce first 3 steps and rest does not happen. However as you said, once I click outside the shape and hit <Ctrl>-<Z> another time, it reverts to the original state.

Version: 6.4.0.0.alpha1+ (x86)
Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 8 Gerald Pfeifer 2020-01-21 18:49:18 UTC
On my end I've seen this with Version: 6.5.0.0.alpha0+
Build ID: 350d25da375f221edfa37309324ce3c68cf297ef
CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-01-12_12:14:47
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 9 Oliver Grimm 2020-01-27 22:13:13 UTC
confirmed here on

Version: 6.3.4.2.0+
Build-ID: 1:6.3.4-2
CPU-Threads: 2; BS: Linux 5.4; UI-Render: Standard; VCL: kde5; 
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded

I cannot confirm step 4 though. Instead of the lines being centered, they are reverted to "aligned right" here. But in any case it's a bug.
Comment 10 Xisco Faulí 2020-01-28 15:57:55 UTC
Reproduced in

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

but not in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 11 Xisco Faulí 2020-01-28 15:58:44 UTC
@Jim, I thought you might be interested in this issue...
Comment 12 Aron Budea 2020-02-01 08:11:20 UTC
(In reply to Xisco Faulí from comment #10)
> but not in
> 
> Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
I don't see it being correct in any version. Perhaps the end result is slightly different, but still goes step-by-step, and doesn't result in what the original list looked like.
Comment 13 Jim Raykowski 2020-10-18 04:23:23 UTC
For me this seems to work correctly using the sample document, other than the undo control not becoming active, when it is: 

1) saved in ODF Presentation format .odp
2) closed
3) reopened
4) tested

Version: 7.1.0.0.alpha0+
Build ID: e385efc6bf5d084759be4fd02f272a75c053fbc5
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 14 QA Administrators 2022-10-19 03:33:38 UTC Comment hidden (obsolete)
Comment 15 Gerald Pfeifer 2022-10-19 07:34:44 UTC
This - steps 2, 3, and 4 being wrong - still happens with

  Version: 7.3.8.0.0+ / LibreOffice Community
  Build ID: 0f7fb0a2decec3f8869098ae5e47ee6055545486
  CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

and

  Version: 7.4.3.0.0+ / LibreOffice Community
  Build ID: f9a3adc186b31bac198d944a03a7b53dd926da23
  CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

which are the latest snapshots as of today (2022-10-19).


Current head has improved and no longer loses the bullet points, so
the remaining problem is that it takes hitting <Ctrl>-<Z> three times
instead of just once to properly undo:

  Version: 7.5.0.0.alpha0+ / LibreOffice Community
  Build ID: 4d9b83a417bbde8148b67d2ab0abe9f4ae285276
  CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

Only the first item in my comment #6 is still open.
Comment 16 QA Administrators 2024-10-19 03:17:56 UTC Comment hidden (obsolete)
Comment 17 Gerald Pfeifer 2024-10-19 10:32:58 UTC
This still happens, though as noted in comment #6 in a reduced form:

Undo works properly, just requires three steps (<Ctrl>-<Z>) instead of
one after right aligning the text in the right object.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cf912b08e4a22f66ab1ec5fa601ba3e50e3c4cc
CPU threads: 12; OS: Linux 6.11; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US