Bug 130131 - There is no Split item in combined shape's context menu in Draw
Summary: There is no Split item in combined shape's context menu in Draw
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.3.0 target:7.2.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Context-Menu
  Show dependency treegraph
 
Reported: 2020-01-22 19:41 UTC by Roman Kuznetsov
Modified: 2021-12-06 13:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2020-01-22 19:41:19 UTC
Description:
There is no Split item in combined shape's context menu in Draw

Steps to Reproduce:
1. Open Draw
2. Draw two any shapes with overlap
3. Select both shapes 
4. Right click
5. Select Shapes->Combine
6. Right click on result
7. Try Split result shape from context menu=> there is no Split item there

Actual Results:
There is no Split item in combined shape's context menu in Draw

Expected Results:
There is Split item in combined shape's context menu in Draw


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.2.1 (x64)
Build ID: fcd633fb1bf21b0a99c9acb3ad6e526437947b01
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but Split item was in context menu in 6.1 version, so it's a regression
Comment 1 V Stuart Foote 2020-01-23 15:28:48 UTC
@Roman, assume you did not mean Group/Un-group

But confirm that the context menu for selected Shapes does not offer the pairing

Combine (.uno:Combine) / Split (.uno:Dismantle)

that is present from the Main menu's Shape menu.

But should be able to customize to add it to the context menu.

Unfortunately when attempting to customize the context menu I can not identify which Draw Context menu would be target to hold the Split control to match the Combine control. I could not even find in the Context menu customization where the Combine action is included.

@Maxim, are the Combine / Split special cases?
Comment 2 V Stuart Foote 2020-01-23 15:35:27 UTC
The .uno:combine, .uno:Dismantle are context aware--combine will not enable until two shapes are selected, dismantle will not enable until a result of a combine is selected.  Works like that on the menu, but while the combine is present with context menu after selection--I can not find it on any of the Shape targets. While as noted the split (dismantle) does not appear on the context menus.

Both UNO actions are available for use via the customization dialog.
Comment 3 Maxim Monastirsky 2020-01-23 15:43:46 UTC
When 2 shapes are selected, there is a special context menu "Multiple Selection", which holds the combine command.

After the shapes are combined, they're considered as a single shape, so the "Shape" context menu is in action.
Comment 4 V Stuart Foote 2020-01-23 15:52:15 UTC
(In reply to Maxim Monastirsky from comment #3)
> When 2 shapes are selected, there is a special context menu "Multiple
> Selection", which holds the combine command.
> 
> After the shapes are combined, they're considered as a single shape, so the
> "Shape" context menu is in action.

Thanks Maxim, I was able to customize the Shape target with the Split (.uno:Dismantle). Alittle obscure as to the interplay.

@Roman, is that ability to customize the context menu sufficient for a WFM? Would think this is more for the "Eve" advanced user anyway.
Comment 5 andreas_k 2020-03-03 21:53:43 UTC
In master (and I think also in actual releases) there are the following commands available in the draw context menu.

  <menu:menu menu:id=".uno:PolyFormen">
    <menu:menupopup>
      <menu:menuitem menu:id=".uno:Combine"/>
      <menu:menuitem menu:id=".uno:Dismantle"/>
      <menu:menuitem menu:id=".uno:Connect"/>
      <menu:menuitem menu:id=".uno:Break"/>
      <menu:menuseparator/>
      <menu:menuitem menu:id=".uno:Merge"/>
      <menu:menuitem menu:id=".uno:Substract"/>
      <menu:menuitem menu:id=".uno:Intersect"/>
      <menu:menuseparator/>
      <menu:menuitem menu:id=".uno:EqualizeWidth"/>
      <menu:menuitem menu:id=".uno:EqualizeHeight"/>
    </menu:menupopup>
  </menu:menu>

as written you have to select multiple shapes and the commands will be show only if there are active/available.

So I'm not sure, but I think this bug is already fixed or did I miss something?
Comment 6 Maxim Monastirsky 2020-03-03 22:13:33 UTC
(In reply to andreas_k from comment #5)
> In master (and I think also in actual releases) there are the following
> commands available in the draw context menu.
> 
>   <menu:menu menu:id=".uno:PolyFormen">
>     <menu:menupopup>
>       <menu:menuitem menu:id=".uno:Combine"/>
>       <menu:menuitem menu:id=".uno:Dismantle"/>
>       <menu:menuitem menu:id=".uno:Connect"/>
>       <menu:menuitem menu:id=".uno:Break"/>
>       <menu:menuseparator/>
>       <menu:menuitem menu:id=".uno:Merge"/>
>       <menu:menuitem menu:id=".uno:Substract"/>
>       <menu:menuitem menu:id=".uno:Intersect"/>
>       <menu:menuseparator/>
>       <menu:menuitem menu:id=".uno:EqualizeWidth"/>
>       <menu:menuitem menu:id=".uno:EqualizeHeight"/>
>     </menu:menupopup>
>   </menu:menu>

This is from multiselect.xml, but here we need it in draw.xml (see comment 3).
Comment 7 Aron Budea 2020-03-09 00:53:19 UTC
For the record, it regressed in the following commit.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cf8b3a74e8c093dd0ffc7e2f431a26864958f6fb
author		andreas kainz <kainz.a@gmail.com>	2018-10-19 01:10:37 +0200
committer	andreas_kainz <kainz.a@gmail.com>	2018-10-22 14:28:02 +0200

tdf#119506 Draw Contextmenu in Writer, Calc, Draw, Impress
Comment 8 Justin L 2021-11-23 06:04:37 UTC
1.5 years of inactivity with a bibisect and all. Wow. It took me 30 minutes to review and produce proposal https://gerrit.libreoffice.org/c/core/+/125681.
Comment 9 Commit Notification 2021-11-24 05:36:39 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b7a46259eba35257291fe00851252c18ffb4fc90

tdf#130131 UI: add back "Split" to draw/impress popup

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-11-25 14:07:19 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/8b5783266357b600e58bd757fef1f34f942b2d58

tdf#130131 UI: add back "Split" to draw/impress popup

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Christian Lohmaier 2021-12-06 13:28:48 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard