Description: When you are in the dialog or macros organizer in LibreOffice Basic, and you add either a module or a dialog, Catalog object doesn't refresh. You can close the IDE and reopen it, and it is ok though. Steps to Reproduce: 1. Open macros organizer 2. Add a module or dialog (haven't tried with libraries, I guess it's the same) 3. Look at the objects catalog pane ("Catalogo de objetos" in my language) Actual Results: Doesn't update Expected Results: Update automatically to show the new catalog object Reproducible: Always User Profile Reset: No Additional Info:
This seems to have begun at the below commit. Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one? Thanks bibisect-linux-64-6.4 1422df3e1338ce034c616dfbc3248b0fb3436c7f is the first bad commit commit 1422df3e1338ce034c616dfbc3248b0fb3436c7f Author: Jenkins Build User <tdf@pollux.tdf> Date: Thu Jun 13 02:07:30 2019 +0200 source ad1cbee2ffc7b3c10cad6fd69f5e4b523ac4027c author Caolán McNamara <caolanm@redhat.com> 2019-06-07 15:42:52 +0100 committer Caolán McNamara <caolanm@redhat.com> 2019-06-12 21:44:39 +0200 commit ad1cbee2ffc7b3c10cad6fd69f5e4b523ac4027c (patch) tree deb0368f573238325c4e30bf1b932e6b3e0c05a2 parent 0e27158c4f6a6a7676a77afb6b37dd30b3f6d100 (diff) weld OrganizeDialog
Moving to NEW
Created attachment 157774 [details] screencast from 6-4 am I using the wrong thing ?, it seems to work for me when I try it
Created attachment 157775 [details] printscreen from LO 7 Hello Caolan, please click on Untitled 1, then click New, confirm dialog.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b97af2719c739649d86a8ec1cc1d0c2d38b26697 Related: tdf#130161 invalid iterator used in BrowseMode::Subs case It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/020ee2fcc1a40415dca8e974cf30834667f55036 Related: tdf#130161 invalid iterator used in BrowseMode::Subs case It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/185915aabde2418d99d16d6b7d9efc39f5cc0fe6 Related: tdf#130161 invalid iterator used in BrowseMode::Subs case It will be available in 6.3.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I can't find evidence that document dialog/modules created in the organizer not appearing is a recent regression. If I use the bisect repor and use commit 0e27158c4f6a6a7676a77afb6b37dd30b3f6d100 which is before the indicated commit then it still fails to automatically appear. But https://cgit.freedesktop.org/libreoffice/core/commit/?id=44861f2435a0c487d4fb5b196f7e4fe7f9569396 commit 44861f2435a0c487d4fb5b196f7e4fe7f9569396 Author: Uray M. János <uray.janos@gmail.com> Date: Fri Aug 17 07:29:20 2012 +0200 did change the UpdateObjectCatalog from happening on every MarkDocumentModified to only happening on rDocument.isApplication instead of all documents which seems to be the problem
If I understand the problem correctly it can be worked around by collapsing the document macro tree in the organizer and re-expanding it after the document modules/dialogs are added
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9fd9da5739f5a99330af5601cd0a3a257f9dc529 tdf#130161 adding a document dialog or modules doesn't update catalog It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c81a8f5a12b754efd06681e017066008f00afa6 tdf#130161 detect if a node already had an expansion attempt It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that seems to work in master now