Created attachment 157578 [details]
Steps to Reproduce:
1. New Spreadsheet;
2. Go to "Data > Define Range", and click the "Options" within this dialog.
Help, Cancle and OK falls outside of the screen area, not able to click these buttons.
The maximum dialog height should be the avaiable screen height when "Options" is clicked, so that all these buttons are visible.
Build ID: 0a6ec034dc8088d9de399142bb193ae7d338e645
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3;
Locale: zh-CN (zh_CN.UTF-8); UI-Language: en-US
OS: Fedora 31 x64.
Display: 1366*768, Thinkpad X230i laptop.
I don't have a low resolution screen for check it, but it looks really high when Options section is opened.
possibly we can move that Options block to right side of the dialog?
We require a minimum of 1280x768px and the dialog is 294x430px with Options collapsed or 622px when expanded (KF5). Some other dialogs: 534 properties, 545 functions, 573 conditional formatting.
I wouldn't move the options to the right of the values as this makes not much sense to me. Options is a GtkBox with 8 elements having a spacing of 6. Our HIG defines a spacing between list items of 3 , which might solve the problem. If not, the list of ranges is quite large and could be a bit smaller.
Code pointer: sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
I tried to reproduce the bug at resolution 1368*768
After expanding Options .. Help, Cancel and Ok were visible to be clicked.
I can't reproduce with GTK3 and QT backend.
(In reply to ahmad_g from comment #3)
> I tried to reproduce the bug at resolution 1368*768
It also depends on the desktop environment and the used theme how controls are sized, placed, and spaced. Anyway, the dialog is quite high when expanded and making it smaller is an advantage. The proposed spacing between controls also makes the dialog HIG compliant.
Created attachment 158132 [details]
An proposal for an fix. Make the dialog 2 columns instead of one and don't hide the options.
The benefit is that the form factor is now way better. The con is that Options are always visible, cause if you hide the options it didn't work well (jumping UI).
(In reply to andreas_k from comment #6)
> An proposal for an fix. Make the dialog 2 columns instead of one and don't
> hide the options.
(In reply to Heiko Tietze from comment #2)
> I wouldn't move the options to the right of the values as this makes not
> much sense to me.
thanks for the feedback add an patch.
Spacing is now 3 instead of 6 AND user can change the size of the dialog (resizable is now true)
andreas kainz committed a patch related to this issue.
It has been pushed to "master":
tdf#130346 Define Database Range Dialog smaler spacing and resizing
It will be available in 7.0.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.