Bug 130408 - change "Style" to "Page Style" in "Insert Break" dialog
Summary: change "Style" to "Page Style" in "Insert Break" dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: pranesh ulleri
URL:
Whiteboard: target:7.0.0
Keywords: difficultyBeginner, easyHack, skillDesign, skillUI, topicDesign, topicUI
Depends on:
Blocks: Writer-Page-Break
  Show dependency treegraph
 
Reported: 2020-02-04 01:43 UTC by sdc.blanco
Modified: 2020-03-13 09:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-02-04 01:43:32 UTC
Insert - More Breaks - Manual Break

Enhancement:  Change "Style" to "Page Style" in "Insert Break" dialog box 
because it is only possible to set Page Style.
Comment 1 Dieter 2020-02-04 07:19:56 UTC
+1

sdc.blanco, if you have a layout enhancement request, it's good to add Keyward "needsUXEval" and add Desing-Team to cc (libreoffice-ux-advise@lists.freedesktop.org)
Comment 2 Heiko Tietze 2020-02-04 10:33:38 UTC
No objection but "Style" becomes enabled when "Page break" is selected so it should be clear. But let's do for consistency. When this issue is fixed, we should also apply proper indentation. See also https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog

Code pointer: sw/uiconfig/swriter/ui/insertbreak.ui
Comment 3 pranesh ulleri 2020-02-11 17:40:13 UTC
Hi I have pushed the commit
https://gerrit.libreoffice.org/c/core/+/88470/1
Comment 4 pranesh ulleri 2020-02-11 18:15:48 UTC
(In reply to pranesh ulleri from comment #3)
> Hi I have pushed the commit
> https://gerrit.libreoffice.org/c/core/+/88470/1

could someone pls review
Comment 5 Commit Notification 2020-02-17 13:18:56 UTC
praneshulleri committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cd0afe8ff1d39ed3f9ccaa318f2fd3b0da4da747

tdf#130408 fix

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Adolfo Jayme Barrientos 2020-02-17 13:20:30 UTC
Don’t forget to write a proper commit message before pushing :/
Comment 7 Heiko Tietze 2020-02-17 13:23:56 UTC
Thanks for your patch, Pranesh. The label has changed and the indentation is not an urgent need (nor I'm sure if it's visually needed in this particular case).

A note about the procedure: 

added to CC: Jenkins
moved from CC to REVIEWER: Jenkins

looks weird… Please make sure you upload the patch properly, see https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch. And it would be kind to use a better summary than "fix" (though the important thing here is the reference to tdf#). Anyway, thanks for your patch! Looking forward to review the next - and I promise to be faster now ;-).
Comment 8 Heiko Tietze 2020-02-17 13:26:44 UTC
(In reply to Heiko Tietze from comment #7)
> A note about the procedure: 

Ignore this, it's the usual procedure.
Comment 9 Dieter 2020-03-13 09:04:16 UTC
Verified with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: c63148ba139bd6b9ae7a0f9e24e51f29e5370963
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

Pranesh, thanks for fixing it!