Bug 130431 - Horrible drawinglayer dashed line performance
Summary: Horrible drawinglayer dashed line performance
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords: perf
Depends on:
Blocks:
 
Reported: 2020-02-04 14:47 UTC by Michael Meeks
Modified: 2022-01-08 18:34 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
a photo (432.45 KB, image/png)
2020-02-04 14:47 UTC, Michael Meeks
Details
the sheet for convenience. (66.12 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-02-04 14:48 UTC, Michael Meeks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2020-02-04 14:47:31 UTC
Created attachment 157644 [details]
a photo

Another instance of the dashed line problems - comment on recent FOSDEM Heise - in German about this despairing about performance of LibreOffice:

wget https://github.com/oliworx/LibreOffice-vs-OpenOffice/raw/master/Kassenbuch_2018.ods

This spreadsheet renders horribly slowly despite being rather trivial. The problem it turns out is the fine dotted line borders used in a few places.

I attach a perf top flamegraph picture - though the load this puts on the X server is also quite significant.
Comment 1 Michael Meeks 2020-02-04 14:48:04 UTC
Created attachment 157645 [details]
the sheet for convenience.
Comment 2 Michael Meeks 2020-02-04 14:49:15 UTC
Eike - not a calc problem, but blamed on it [ FYI =]. Armin - I guess another (not so relevant but interesting) symptom of the same dashing problems.
Comment 3 Commit Notification 2020-05-26 13:56:41 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3a93748c9c4faadeb9ab4eb21706d187677549fa

use Skia to do dashed lines, no need to do it manually (tdf#130431)

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 BogdanB 2020-09-19 11:45:26 UTC
This bug has a patch, but appears as new.
Luboš Luňák, can you change that?...
Comment 5 Roman Kuznetsov 2022-01-08 18:34:21 UTC
I do not see the problem in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1be170d0629cf761f0ee4173007a3c021966546e
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Let's close it as FIXED