Bug 130441 - Make Styles command (.uno:DesignerDialog) toggle the sidebar on/off (like F11 does)
Summary: Make Styles command (.uno:DesignerDialog) toggle the sidebar on/off (like F11...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.4.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Button-Controls
  Show dependency treegraph
 
Reported: 2020-02-04 21:22 UTC by sdc.blanco
Modified: 2020-03-06 00:44 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-02-04 21:22:25 UTC
(to see problem, use Tools-Customize-Toolbars tab to add "Apply" to a menu.)

Press the icon.  If The Styles Window was closed, then Style window is opened.
If Styles window is open, then nothing happens.

Request is to have Styles window close (like F11 behavior. See bug #85791)

Reason:  enables quick check (and closing) of window without having to move mouse.  (particularly useful for checking character styles)
Comment 1 sdc.blanco 2020-03-01 15:25:55 UTC
Maybe this can be made an EasyHack?  

Removing needsUXEval, because already indicated in help page.

Currently the toolbar pages for different modules embed the first line of 
https://help.libreoffice.org/7.0/en-US/text/shared/02/01230000.html, which says the icon can also hide the window.
Comment 2 Heiko Tietze 2020-03-02 13:04:27 UTC
You mean .uno:AutoFormatApply? Cannot follow this idea.
Comment 3 sdc.blanco 2020-03-02 13:55:45 UTC
(In reply to Heiko Tietze from comment #2)
> You mean .uno:AutoFormatApply? Cannot follow this idea.
No. I mean:  .uno:DesignerDialog
(at present found on Formatting (Styles) toolbar in Writer, but in principle could be used in toolbars in all modules.)
You can see the icon (and explanation) if you use the link to the helppage.
Comment 4 V Stuart Foote 2020-03-02 14:24:11 UTC
So button action of .uno:DesignerDialog should be the same as the <F11> shortcut, and should toggle the sidebar deck/dialog the same way.

+1 if it can be plumbed like that, can it?
Comment 5 Heiko Tietze 2020-03-02 14:43:22 UTC
Not so sure as sidebar on/off is not switching from any tab such as properties to styles. Why not get rid of one of the two uno commands and, for example, always open styles with Ctrl+F5?

It feels to me as if we had this conversation before but cannot find a reference.
Comment 6 V Stuart Foote 2020-03-02 15:04:06 UTC
The 'Styles...' dialog --> <F11> is ingrained legacy. As is the 'Navigator...' <F5> shortcut from when the .src dialogs were implemented as decks on the Sidebar framework.

Now, as then, what do we gain by changing the legacy <F11> for the Styles deck to be <Ctrl>+<F5> and more tightly relate to the Navigator's usage?

IMHO I don't think we want to go there. Not a lot of benefit to it, diluting what are two very distinct facets of the GUI, while clobbering 20+ years of legacy usage.

Tweaking the 'Styles' (.uno:DesignerDialog) button action to match the <F11> keyboard shortcut (which may require additional control logic) seems more responsible.
Comment 7 Cor Nouws 2020-03-02 21:47:21 UTC
(In reply to sdc.blanco from comment #0)

> Request is to have Styles window close (like F11 behavior. See bug #85791)
No objections to that.

Mind that the menu Styles > Manage styles (F11) doesn't toggle either. Should be done at the same time, I think.
Comment 8 Heiko Tietze 2020-03-05 06:50:39 UTC
We discussed the topic in the design meeting and decided to agree with the request.