Bug 130460 - LibreOffice installer reboots Windows10 machines and destroys all open documents without any safeguard
Summary: LibreOffice installer reboots Windows10 machines and destroys all open docume...
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
6.3.4.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks: Installer-Windows
  Show dependency treegraph
 
Reported: 2020-02-05 16:37 UTC by adam.m.s.martin+libreoffice
Modified: 2020-10-12 04:26 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description adam.m.s.martin+libreoffice 2020-02-05 16:37:15 UTC
Description:
Short description:

The installer aggressively reboots, does NO CHECKS to see if there are unsaved open documents running on the computer (there is no "Are you sure? You are about to lose your data" dialog), and uses a very badly chosen dialog box with words Yes/No, instead of Reboot/Continue.

Long description:

1. Installed latest (6.3.4)
2. The Installer complained that Firefox was using a file it wanted to change (why? LibreOffice shouldn't be doing this anyway! I don't want LO to change my web browser!)
3. Installer then DEMANDED it reboot the computer
4. The dialog box in installer asked "will you reboot later?", the first time so I said Yes, I'll reboot later
5. The dialog box came back a second time (problem 1: this should not happen, I had already answered the question), asking about rebooting later, so I hit Yes.
6. It turns out that the second dialog box is reworded to have the opposite internal meaning (problem 2: this dialog box is over-complicated with bad use of English. Instead of the options "Yes" and "No", it should have options "DELETE ALL DATA", and "Cancel", since one of the buttons is usually guaranteed to cause dataloss)
7. It then rebooted the computer, deleting unsaved data in 4 different applications that were open at the time.

Steps to Reproduce:
1. Install LibreOffice on a new machine
2. 
3.

Actual Results:
Rebooted Windows with no warnings

Expected Results:
Don't reboot windows without at least one level of "are you sure? This will cause data loss, and is unrecoverable" extra dialogs.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 V Stuart Foote 2020-02-05 17:26:02 UTC
Sorry if you've lost any work or data, that should not happen. 

However, to be able to do anything with this issue we would have needed verbose logging of the installation to determine the steps that might be forcing the reboot.

Unlikely, and a "Catch-22", as you've already done the installation, and the system components (usually stale the MSVC++ runtimes) needing update have now already been installed. No real way for the average user to reproduce the issue.

Otherwise, the general guidance for safely performing software installations/upgrades remains valid advise--close out of all programs before attempting an upgrade.

LibreOffice does not provide automatic updates--it will alert to availability of new builds. But the installation is in the users hands.
Comment 2 adam.m.s.martin+libreoffice 2020-02-05 19:11:47 UTC
MSVC++ runtimes makes sense - although this is running latest Firefox, which surely updates runtimes frequently enough already?

From what you're saying ... the rebooting isn't something that LO does deliberately? It appeared to be using LO's style dialog boxes/UI.
Comment 3 V Stuart Foote 2020-02-05 19:51:01 UTC
Well, in addition to the MSVC++ runtimes (which LO will update and require system restart), LO also provides a Windows Explorer shell plugin--but don't think that requires a system restart, just possibly restart of the Explorer shell.

As noted, without a verbose log, we're just guessing what happened for you.
Comment 4 Mike Kaganski 2020-03-14 10:20:26 UTC
(In reply to adam.m.s.martin+libreoffice from comment #0)
> Long description:
> 
> ...
> 3. Installer then DEMANDED it reboot the computer
> 4. The dialog box in installer asked "will you reboot later?", the first
> time so I said Yes, I'll reboot later
> 5. The dialog box came back a second time (problem 1: this should not
> happen, I had already answered the question), asking about rebooting later,
> so I hit Yes.
> 6. It turns out that the second dialog box is reworded to have the opposite
> internal meaning (problem 2: this dialog box is over-complicated with bad
> use of English. Instead of the options "Yes" and "No", it should have
> options "DELETE ALL DATA", and "Cancel", since one of the buttons is usually
> guaranteed to cause dataloss)

Oh it's always sad to see people not even trying to read, then claim others to be guilty...

When the installer detects that some process(es) for some reason block resources it needs to update, it checks if it is possible to use Windows Restart Manager service to restart this process. If it is possible, the installer shows this dialog:

====================
The following applications are using files that need to be updated by this setup. You can let Installation Wizard close them and attempt to restart them or reboot the machine later."

[list of processes blocking resources]

() Close the applications and attempt to restart them.
() Do not close applications. A reboot will be required.

[OK] [Cancel]
====================

If it cannot close that process using Windows Restart Manager service, it asks this question:

====================
The setup must update files or services that cannot be updated while the system is running. If you choose to continue, a reboot will be required to complete the setup.

[OK] [Cancel]
====================

In both cases, if user chose to restart later, it proceeds to install, and when it's finished what was possible to do before reboot, it shows this:

====================
You must restart your system for the configuration changes made to LibreOffice 6.4.2.2 to take effect. Click Yes to restart now or No if you plan to restart later.

[Yes] [No]
====================

So much attention was paid to make the wording in the dialog shown initially clear that if one chooses to proceed (without closing and restarting the blocking process), a restart would be required when installation finishes; and when it finishes, the message tries hard to make it clear. It even has *different* buttons: [Yes] and [No] instead of radio buttons and [OK] [Cancel]. But no matter how hard you try, you cannot persuade users to read it when users like to believe they know what is there without reading. And - well, even *if* we could change buttons in the dialog (which we can't: it only allows us to change wording of the message), personally for myself, seeing the proposed [DELETE ALL DATA] instead of [Yes] would be offensive, trying to demean me.

There's one more thing: while the wording is (partially) controlled by installer database (MSI), the behaviour itself is controlled by *Windows system service* named "Windows Installer" (msiexec), which itself does all the magic to detect the processes blocking updated files (list of which is taken from MSI); if it's possible to use Restart Manager; and *how to perform the reboot* when user agrees to reboot (which means, that it's not LibreOffice that decides to reboot "aggressively" and without "are you sure?", but system service, and that it's how Microsoft deems it conforming to its system philosophy).
Comment 5 Mike Kaganski 2020-03-14 10:32:56 UTC
https://gerrit.libreoffice.org/c/core/+/90396
Comment 6 Commit Notification 2020-03-14 11:13:50 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f101283b01223c766505a941130bd66a7b3d08d0

tdf#130460: clarify the option some more

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 QA Administrators 2020-09-11 03:51:00 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2020-10-12 04:26:55 UTC
Dear adam.m.s.martin+libreoffice,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp