Bug 130571 - Add server os pretty name to help->about
Summary: Add server os pretty name to help->about
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillCpp, skillJavaScript, topicDebug
Depends on:
Blocks:
 
Reported: 2020-02-10 20:08 UTC by Michael Meeks
Modified: 2020-04-03 21:45 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2020-02-10 20:08:55 UTC
Help->About shows some useful data from LOOLWSD which is injected into the main page template: online/loleaflet/html/loleaflet.html.m4 - which is built by 'config.status'.

Anyhow - we should include another variable into this, which we can fill in in online/wsd/FileServer.cxx with another Poco::replaceInPlace - with the contents of /etc/os-release's PRETTY_NAME - so we can help diagnose platform-specific issues more easily.

For bonus points we should also remove the 'Poco' bits, and parse the string into a stringstream - and lookup each variable as/when we find it - rather than re-searching through the whole message endlessly for various different variables to substitute: faster, more efficient, and de-poco-ized.

Thanks !
Comment 1 Hugo Eduardo Ziviani 2020-03-18 19:55:44 UTC
Hello, could you give more information to me get this problem? Let me know if I understood good. Is that a request to replace some words with better names? Thanks
Comment 2 Xisco Faulí 2020-03-18 20:00:04 UTC
Hello Hugo,
NEEDINFO is used when information from the reported is needed in order to triage a bug, not for support on easyHacks. Please, do not change it.
Comment 3 Michael Meeks 2020-03-18 21:36:48 UTC
Hugo - please work harder at your research; go around the hermenutical spiral five times =) read the code I pointed at, cat /etc/os-release, get a build & see what it does currently - and you'll be able to answer your own question.

Thanks! =)
Comment 4 Gökay ŞATIR 2020-03-29 18:59:11 UTC
May i assign this subject to myself? I started to work on this.
Comment 5 Buovjaga 2020-03-30 06:20:13 UTC
(In reply to Gökay ŞATIR from comment #4)
> May i assign this subject to myself? I started to work on this.

That depends on if Hugo is still working on this.
Comment 6 Hugo Eduardo Ziviani 2020-03-30 11:49:47 UTC
Ok. I'm working on this.
Comment 7 Hugo Eduardo Ziviani 2020-03-30 12:22:46 UTC
(In reply to Michael Meeks from comment #3)
> Hugo - please work harder at your research; go around the hermenutical
> spiral five times =) read the code I pointed at, cat /etc/os-release, get a
> build & see what it does currently - and you'll be able to answer your own
> question.
> 
> Thanks! =)

Michael, hello! I hope everything is going good. So, I thought something like this to this error:

awk -F= '$1=="ID" { print $2 ;}' /etc/os-release

This simple line can return just the name of OS. What do you think? I'm going to the right way?
Comment 8 Michael Meeks 2020-03-30 12:44:35 UTC
Hugo - we already have a patch here so I'd suggest looking at another bug.
    https://gerrit.libreoffice.org/c/online/+/91345

Using another shell, and spawning an AWK process seems really sub-optimal to me when that can be parsed in native code trivially. We want to depend on as few details of the system, and other tools as possible really.

Thanks.
Comment 9 Andras Timar 2020-04-02 11:57:02 UTC
gokaysatir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/a486bad79be3838d115e09ccbb55ec47ea36274a

tdf#130568 - Add server os pretty name to help->about

(he used wrong bug reference though...)