This is a follow-up of bug 108881 since the original steps are still reproducible Steps to reproduce 1. Open the attachment 134418 [details] from bug 108881 2. Cut the Ole Chart object 3. Close the Calc document (gray cross). No saving. 4. Open Calc from start center 5. Paste the Ole object -> Crash Reproduced in Version: 7.0.0.0.alpha0+ Build ID: 718f540fb63af27c1336f89213444e9af753b8a9 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Can be reproduced right after http://cgit.freedesktop.org/libreoffice/core/commit/?id=4d783c45062d030d278c076d7817b9589fa77d91, so it didn't fix the particular crash
This seems to have begun at the below commit. Adding Cc: to Kohei Yoshida ; Could you possibly take a look at this one? Thanks commit 36d197c0646cd054145c7edcd7fb906b13c610a8 Author: Matthew Francis <mjay.francis@gmail.com> Date: Fri Sep 18 10:21:27 2015 +0800 source-hash-c55d52262ea1d5f869a9528fd051ee19e687f1cc commit c55d52262ea1d5f869a9528fd051ee19e687f1cc Author: Kohei Yoshida <kohei.yoshida@gmail.com> AuthorDate: Fri Jan 18 14:36:33 2013 -0500 Commit: Kohei Yoshida <kohei.yoshida@gmail.com> CommitDate: Fri Jan 18 14:41:42 2013 -0500 fdo#58988, fdo#58562: Populate draw clip document with data for charts. Without populating the clip document, copying a chart (or charts) into clipboard makes the charts lose all their referenced data, which causes the pasted chart to appear empty. Change-Id: I3675f76baed19b48cec403964c19df00725a044b
@Dennis, since you fixed bug 108881 I thought you might be interested in this issue as well
This is a follow-up of bug 108887 since the original steps are still reproducible Steps to reproduce 1. Open attachment 134425 [details] from bug 108887 2. Copy the formula somewhere around C6 3. Close Calc (gray cross) 4. Open New calc document 5. Paste -> Crash Reproduced in Version: 7.0.0.0.alpha0+ Build ID: 718f540fb63af27c1336f89213444e9af753b8a9 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
oh wait, the issue was fixed and now it's broken again. re-checking...
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e4cea049c80f4fd6d2a586e73fe9fa08ebd08371 author Andrés Maldonado <amaldonado@linagora.com> 2019-05-24 17:59:13 +0200 committer Thorsten Behrens <Thorsten.Behrens@CIB.de> 2019-09-08 02:21:36 +0200 commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371 (patch) tree 4a6a69390383a03b2f7d527acdaa7613834fc5be parent 294222866f4d39e200cf365bac77de76b2ae9841 (diff) tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy' Bisected with: bibisect-linux64-6.4 Adding Cc: to Andrés Maldonado
Another way to reproduce it: 1. Open Calc 2. Insert -> Object -> Ole-Object -> Insert a new Ole-object (for example spreadsheet) 3. Cut/Copy the Object 3. Close Calc (gray cross) 4. Open New calc document 5. Paste -> Crash
it also crashes with these steps: 1. Open Calc 2. Insert an empty chart 3. Select it and copy it 4. Close LibreOffice -> Crash!
Xisco Faulí committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/09e6824bc868990095233825c415556399dd0652 tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'" It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'" It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-4-1": https://git.libreoffice.org/core/commit/25937732b9ef881651611f99d4178e90888642a2 tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'" It will be available in 6.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Will take a look - I think the OLE just needs to be cloned to the target model, as the other objects already are...
(In reply to Armin Le Grand from comment #12) > Will take a look - I think the OLE just needs to be cloned to the target > model, as the other objects already are... Hi Armin, Do you mean bug 125520 ?
@cisco -> yupp, right :)
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6bda2e11c553b4032a33b95dd89e762db23e60f3 tdf#130614, tdf#108887: sc_uicalc: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.