Download it now!
Bug 130756 - CRASH: traversing tabs with Ctrl+PageUp/Down (gen)
Summary: CRASH: traversing tabs with Ctrl+PageUp/Down (gen)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.0.0 target:6.4.2 target:6.3.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-02-18 12:29 UTC by Xisco Faulí
Modified: 2020-02-19 11:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature: ["SvTreeList::IsEntryVisible(SvListView%20const%20*,SvTreeListEntry%20*)"]


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-02-18 12:29:19 UTC
Steps to reproduce:
1. Open Writer
2. F11
3. Select any style and modify
4. Click on any tab
5. Hold Ctrl + PageUp or Ctrl + PageDown

-> Crash

reproduced in

Version: 7.0.0.0.alpha0+
Build ID: 28d844a589e52abfe62dc66b888e78665221ba28
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-02-18 12:31:02 UTC
Regression introduced by:

https://gerrit.libreoffice.org/plugins/gitiles/core/+diff/a977098f59a4c931c6f8a1d423720e682f5ed047%5E!

map GtkTreeView to SvTreeViewBox now it is in vcl

commit	a977098f59a4c931c6f8a1d423720e682f5ed047	[log]
author	Caolán McNamara <caolanm@redhat.com>	Mon Nov 05 15:08:47 2018 +0000
committer	Caolán McNamara <caolanm@redhat.com>	Wed Nov 07 22:01:20 2018 +0100
tree	d865c854cc2e6c0151b0b4aea4b7865cc1822585
parent	6311f7ffce8f64b0773d2ad3ea7be3be683924c0 [diff]

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara
Comment 2 Xisco Faulí 2020-02-18 12:33:21 UTC
Same problem in Impress
Comment 3 Commit Notification 2020-02-18 16:25:57 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fe5a839de9b0291e4473ae45b18a540cd5e78ffe

Resolves: tdf#130756 null deref in empty treeview

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2020-02-18 16:28:19 UTC
fixed in master, backports to 6-4 and 6-3 in gerrit
Comment 5 Commit Notification 2020-02-19 09:56:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/27badf859389b20d03b96e7459a8110bc48224db

Resolves: tdf#130756 null deref in empty treeview

It will be available in 6.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-02-19 09:56:51 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/eca9a29eb18048c40e05f6343fc0306f63d23f14

Resolves: tdf#130756 null deref in empty treeview

It will be available in 6.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2020-02-19 11:25:16 UTC
Verified in

Version: 7.0.0.0.alpha0+
Build ID: bc994a4b01cf61444452bb377010c7c4cc377698
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!