Bug 130874 - EDITING: Form - tablecontrol - column width couldn't be set by direct dialog
Summary: EDITING: Form - tablecontrol - column width couldn't be set by direct dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.0.0 target:6.4.2 target:6.3.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-02-22 17:16 UTC by Robert Großkopf
Modified: 2020-02-26 10:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of empty dialog for column-width (16.89 KB, image/png)
2020-02-22 17:16 UTC, Robert Großkopf
Details
Database with a tablecontrol for testing (10.69 KB, application/vnd.oasis.opendocument.database)
2020-02-22 17:17 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2020-02-22 17:16:24 UTC
Created attachment 158102 [details]
Screenshot of empty dialog for column-width

Open the attached screenshot.
It shows the column-with dialog you could choose when clicking on right mouse-button on a table-control-header and choose Column Width. This field is empty, but the width of the chosen field is 5 cm. This will be shown in older LO-versions like LO 6.1.5.2, but isn't shown in versions like 6.3.4.2 or 6.4.0.3 or a daily build from 2020-02-15.

You could change the width in this dialog if there is any value. But the field "Width" is set to input nothing. There will only appear a value if you set it to "Automatic".

Note: You could change the width if you choose the properties of the field by right mouse click on the column-header. This will work in all versions.

All tested with OpenSUSE 15.1 64bit rpm Linux
Comment 1 Robert Großkopf 2020-02-22 17:17:18 UTC
Created attachment 158103 [details]
Database with a tablecontrol for testing
Comment 2 Robert Großkopf 2020-02-22 17:48:50 UTC
This bug first appears here with
Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 6; OS: Linux 4.12; UI render: default; VCL: kde5; 
Locale: de-DE (de_DE.UTF-8); UI-Language: en-US
Calc: threaded

I have set the version to this version.
Comment 3 Xisco Faulí 2020-02-25 11:50:56 UTC
Not reproduce it in

Version: 7.0.0.0.alpha0+
Build ID: e6b9bc3f2ecf0fb7fde5b02f9d750ccbe022f4c1
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 4 Xisco Faulí 2020-02-25 11:51:59 UTC
but reproduced in

Version: 7.0.0.0.alpha0+
Build ID: e6b9bc3f2ecf0fb7fde5b02f9d750ccbe022f4c1
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 5 Xisco Faulí 2020-02-25 11:58:33 UTC
not a regression,
I can reproduce it in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 6 Xisco Faulí 2020-02-25 12:09:42 UTC
ouch, actually it's a regression, my bad. At first i thought the issue was about the spinbutton not getting greyed out but blank.

Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2018-10-03 21:18:31 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-10-04 09:56:42 +0200
commit fd5e9b1eb383e380d7eef4d168f2f5f85d2ab819 (patch)
tree e94e18d99d07cc1eb97d93cd2c0cc5c63d98897d
parent 7e86cfab8ee1f7fdcb42f37e2b0b7a5ab5d862c1 (diff)
weld DlgSize

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara
Comment 7 Xisco Faulí 2020-02-25 12:11:13 UTC
Also happening with gtk3. The problem is: if automatic is selected, input should be disabled, and viceversa
Comment 8 Commit Notification 2020-02-25 19:51:19 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/72a5c8a6f5d5515aed47ff803bc277353aa54061

Resolves: tdf130874 reversed logic

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2020-02-25 19:52:09 UTC
fixed in master, backports to 6-4 and 6-3 in gerrit
Comment 10 Xisco Faulí 2020-02-26 10:05:36 UTC
Verified in

Version: 7.0.0.0.alpha0+
Build ID: c8d764b3f27c2bb0712745891b70630e94436317
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!!
Comment 11 Commit Notification 2020-02-26 10:06:30 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/b767f6d92e8c055d0313a31bce1caec3ccaddeb0

Resolves: tdf130874 reversed logic

It will be available in 6.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2020-02-26 10:21:06 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/c38e37606d71cfbefa9d9c9eb92b7a8b28f6ebea

Resolves: tdf130874 reversed logic

It will be available in 6.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.