Bug 130974 - Drop rtl::math::isSignBitSet in favor of std::signbit
Summary: Drop rtl::math::isSignBitSet in favor of std::signbit
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Yukio Siraichi
URL:
Whiteboard: target:7.0.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2020-02-27 05:54 UTC by Mike Kaganski
Modified: 2020-03-14 08:31 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2020-02-27 05:54:19 UTC
std::signbit is there since C++11 [1]. Let's replace home-grown rtl::math::isSignBitSet (declared/defined in include/rtl/math.hxx) with this standard function.

[1] https://en.cppreference.com/w/cpp/numeric/math/signbit
Comment 1 Stephan Bergmann 2020-02-27 07:41:34 UTC
It is fine to remove uses of that rtl::math function across the LO code base.  But the function is part of the stable URE interface, so cannot easily itself be removed.

(We can think about an [API CHANGE] to drop this and similar inline functions from rtl/math.hxx once all of them are unused across the LO code base.)
Comment 2 Commit Notification 2020-03-14 08:11:20 UTC
Yukio Siraichi committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8f8b64cad377c6d767cdf291fd00225658bd02c5

tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.