Bug 130976 - Drop rtl::math::isInf in favor of std::isinf
Summary: Drop rtl::math::isInf in favor of std::isinf
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Yukio Siraichi
URL:
Whiteboard: target:7.0.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2020-02-27 06:09 UTC by Mike Kaganski
Modified: 2020-03-13 15:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2020-02-27 06:09:47 UTC
std::isinf is there since C++11 [1]. Let's replace home-grown rtl::math::isInf (declared/defined in include/rtl/math.hxx) with this standard function.

[1] https://en.cppreference.com/w/cpp/numeric/math/isinf
Comment 1 Stephan Bergmann 2020-02-27 07:42:00 UTC
It is fine to remove uses of that rtl::math function across the LO code base.  But the function is part of the stable URE interface, so cannot easily itself be removed.

(We can think about an [API CHANGE] to drop this and similar inline functions from rtl/math.hxx once all of them are unused across the LO code base.)
Comment 2 Yukio Siraichi 2020-03-12 10:08:55 UTC
I think I will also take this one. Should I keep leaving these comments, or can I just assign the issue to myself?
Comment 3 Mike Kaganski 2020-03-12 10:13:08 UTC
(In reply to Yukio Siraichi from comment #2)

It's OK to just assign to yourself. Thank you!
Comment 4 Commit Notification 2020-03-12 19:06:57 UTC
Yukio Siraichi committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c95529ed8eee120c109cd6fc7c94f615606586b0

tdf#130976 replace `rtl::math::isInf` with `std::inf`.

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.