std::isfinite is there since C++11 [1]. Let's replace home-grown rtl::math::isFinite (declared/defined in include/rtl/math.hxx) with this standard function. [1] https://en.cppreference.com/w/cpp/numeric/math/isfinite
It is fine to remove uses of that rtl::math function across the LO code base. But the function is part of the stable URE interface, so cannot easily itself be removed. (We can think about an [API CHANGE] to drop this and similar inline functions from rtl/math.hxx once all of them are unused across the LO code base.)
Can I take this issue as my first contribution?
(In reply to Yukio Siraichi from comment #2) Of course, please assign it to you and proceed; looking forward to see your first contribution!
So, I created a fix on gerrit, and apparently Jenkins accepted it. Should I assign the reviewers myself? https://gerrit.libreoffice.org/c/core/+/90234
Yukio Siraichi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8e173a965d5684372e3fe0ee3d3599032bcb86c2 tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`. It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.