Bug 131075 - LibreLogo Help Incorrect ~ Function Calls
Summary: LibreLogo Help Incorrect ~ Function Calls
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
6.3.5.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: LibreLogo Help-Changes-Features
  Show dependency treegraph
 
Reported: 2020-03-02 15:43 UTC by George 2.0 Hope
Modified: 2022-12-10 07:51 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description George 2.0 Hope 2020-03-02 15:43:28 UTC
Description:
On the following help page:

 ○ https://help.libreoffice.org/6.2/en-US/text/swriter/librelogo/LibreLogo.html

It states:

[[[...

 • Alternative parenthesization in function calls

 TO star size color
 FILLCOLOR color
 REPEAT 5 [ LEFT 72 FORWARD size RIGHT 144 FORWARD size ]
 FILL
 END
 
 star 100 “red”
 star (100, “green”)
 star(100, “blue”)

...]]]

You will get an error on line 8; this is incorrect line:

 star (100, “green”)

When using parenthesis after a function call, you cannot have a space.

This line should simply be deleted from the documentation, as when corrected, it is the same as the following (correct) statement:

 star(100, “blue”)


System Info:

Version: 6.3.5.2 (x64)
Build ID: dd0751754f11728f69b42ee2af66670068624673
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Steps to Reproduce:
1. Enter the following text in Writer:

 TO star size color
 FILLCOLOR color
 REPEAT 5 [ LEFT 72 FORWARD size RIGHT 144 FORWARD size ]
 FILL
 END
 
 star 100 “red”
 star (100, “green”)
 star(100, “blue”)

2. Click [Run] button from LibreOffice Writer LibreLogo Toolbar

Actual Results:
Error on Line 8

Expected Results:
It successfully calls the [star] function, & redraws a green star over the prior red star... and continues execution.


Reproducible: Always


User Profile Reset: No



Additional Info:
The help documentation on the following page needs corrected:

https://help.libreoffice.org/6.2/en-US/text/swriter/librelogo/LibreLogo.html

Both UserProfile & OpenGL are irrelevant to this problem.
Comment 1 Xisco Faulí 2020-05-13 12:02:13 UTC
@László Németh, do you agree with the description ?
Comment 2 László Németh 2020-05-14 09:13:09 UTC
Indeed, that line is obsolete from LibreOffice 6.2:

Compiling Logo expressions to Python, i.e. adding parentheses at the right places uses a parser instead of the former heuristic method. Thus, you can write arbitrarily complex expressions, either in combination with Python lists, and calling own Logo functions with more than one argument without parentheses. Note: In LibreLogo expressions you can use Logo and Python syntaxes at one time. To avoid conflict, now parenthesis directly following the function name, eg. in “sin(x) * 2” denotes Python syntax, (meaning 2·sin(x)), while the space separated version, eg. “sin (x) * 2”, denotes Logo syntax (meaning “sin(2·x)”, as the simpler Logo expression “sin x * 2”).

(http://librelogo.org/2018/11/16/improvements-in-libreoffice-6-2/)

Thanks for your bug report! I am going to fix it soon.
Comment 3 Xisco Faulí 2021-02-09 14:22:59 UTC
Dear László Németh,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.
Comment 4 Julien Nabet 2022-12-03 13:34:30 UTC
Change waiting for review here:
https://gerrit.libreoffice.org/c/help/+/143577
Comment 5 Commit Notification 2022-12-03 13:49:29 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/a222befecb3808d06b6ae208cff9a055892051e4

tdf#131075: LibreLogo Help Incorrect ~ Function Calls