Bug 131111 - Minimum image size listed as 1.00cm when it should be 0.51cm.
Summary: Minimum image size listed as 1.00cm when it should be 0.51cm.
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.0.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-03-04 06:59 UTC by Justin L
Modified: 2020-03-04 17:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (120.81 KB, image/png)
2020-03-04 09:37 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2020-03-04 06:59:06 UTC
Using attachment 131240 [details] from bug 83734#c6, the first image has a very high dpi count, but very small dimensions. However, in the properties the original size is now listed with as 1.00cm X 1.00cm instead of a more accurate 0.52 X 0.39 cm.

This was caused by commit 14cb677a4325ac3e4e150f10a62f15e744093bf4 in LO 7.0
Author: Caolán McNamara   Fri Feb 14 15:31:59 2020 +0000
    remove MetricField use from cui

The second image shows why this is a problem.  The cropping numbers are based on the original size, and so a cropping of 0.18cm appears as if 18% of the image is being cropped out, when in fact it is closer to 30%.  So without valid original image size values, it is just guesswork to figure out the numbers required to get the cropping that you want.
Comment 1 Xisco Faulí 2020-03-04 09:37:34 UTC
Created attachment 158373 [details]
screenshot
Comment 2 Xisco Faulí 2020-03-04 09:38:16 UTC
Reproduced in

Version: 7.0.0.0.alpha0+
Build ID: c57d6d39c80844c9d4c6bfed85cc151e52a67b34
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 3 Caolán McNamara 2020-03-04 10:24:43 UTC
I imagine, from Xisco screenshot, we're talking about the crop tabpage
Comment 4 Justin L 2020-03-04 10:26:22 UTC
(In reply to Caolán McNamara from comment #3)
> I imagine, from Xisco screenshot, we're talking about the crop tabpage
Correct.
Comment 5 Commit Notification 2020-03-04 11:38:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1e4e57afb50f25b5b7c4f24b3fb4d96c71e25b92

tdf#131111 we want a min of 0 not 1 for this formatting spinbox

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2020-03-04 11:58:14 UTC
an incorrect min of 1 was involved there, should be ok now
Comment 7 Justin L 2020-03-04 17:10:00 UTC
Thanks Caolán