Bug 131123 - WOPI save failure not reported
Summary: WOPI save failure not reported
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.0.0.beta0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-04 14:23 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2020-07-01 16:27 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2020-03-04 14:23:41 UTC 
When saving via postMessage (Action_Save) you get a response via Action_Save_Resp, which contains a "success" parameter.

This parameter is always true, even if saving in the WOPI host failed.

The parameter should reflect whether saving was successful or not.

Additionally, delivering the error string reported by the WOPI host, would also be nice.
Comment 1 Xisco Faulí 2020-03-19 11:45:24 UTC 
Moving to NEW
Comment 2 Commit Notification 2020-05-29 06:41:05 UTC 
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/665b1629de30a4a402c6b10dd542de158db1f428

tdf#131123 Report back save result
Comment 3 Commit Notification 2020-07-01 15:58:50 UTC 
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/9f8fdb7bd7b12c1591e2c118e59ea3154844c960

tdf#131123 Report back real save result
Comment 4 Commit Notification 2020-07-01 16:27:01 UTC 
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/online/commit/59d121bd26ce0a03fc5ec962faee65ec85f2d0ed

tdf#131123 Report back save result