Bug 131153 - Incorrect LongDateDaySeparator for fr_CH and it_CH
Summary: Incorrect LongDateDaySeparator for fr_CH and it_CH
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Jean-Louis Fuchs
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-05 12:14 UTC by Jean-Louis Fuchs
Modified: 2020-07-22 15:12 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
How the edit fields dialog looks (Capture-Edit_Fields-CH.png) (39.11 KB, image/png)
2020-03-05 12:15 UTC, Jean-Louis Fuchs
Details
How the edit fields dialog should look (Capture-Edit_Fields-FR.png) (40.10 KB, image/png)
2020-03-05 12:17 UTC, Jean-Louis Fuchs
Details
Fix fr_CH (2.20 KB, patch)
2020-03-05 12:28 UTC, Jean-Louis Fuchs
Details
Fix it_CH (2.21 KB, patch)
2020-03-05 12:28 UTC, Jean-Louis Fuchs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Louis Fuchs 2020-03-05 12:14:30 UTC
Description:
According to localeplanet [1] [2], in comparison to other software and people living it these areas, the LongDateDaySeparator '.' for fr_CH and it_CH in LibreOffice is not correct. It should be omitted.

[1] http://www.localeplanet.com/icu/it-CH/index.html
[2] http://www.localeplanet.com/icu/fr-CH/index.html

This means for the FormatElement index 22, 23, 24, 25, 26 should be the same in fr_CH/fr_FR and it_CH/it_IT.

I attached patches that fixes this.

Steps to Reproduce:
1. Go to the edit fields dialog on a date

Actual Results:
See image Capture-Edit_Fields-CH.png

Expected Results:
See image Capture-Edit_Fields-FR.png


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.2.2
Build ID: 038556d6447f40588f422f7c60935eca7afd6629
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Jean-Louis Fuchs 2020-03-05 12:15:35 UTC
Created attachment 158406 [details]
How the edit fields dialog looks (Capture-Edit_Fields-CH.png)
Comment 2 Jean-Louis Fuchs 2020-03-05 12:17:09 UTC
Created attachment 158407 [details]
How the edit fields dialog should look (Capture-Edit_Fields-FR.png)
Comment 3 Jean-Louis Fuchs 2020-03-05 12:28:00 UTC
Created attachment 158408 [details]
Fix fr_CH
Comment 4 Jean-Louis Fuchs 2020-03-05 12:28:31 UTC
Created attachment 158409 [details]
Fix it_CH
Comment 5 Julien Nabet 2020-03-06 21:03:42 UTC
Great job!

Would you be interested in submitting your patches?
Indeed it seems you made 95% of the task!
- retrieve sources
- prepare your env and build sources
- find root cause
- patch and test

The remaining 5% is:
- create a gerrit account
- send your license statement
- submit the patches

Everything is here:
https://wiki.documentfoundation.org/Development/GetInvolved
Comment 6 Jean-Louis Fuchs 2020-03-10 12:30:05 UTC
> Everything is here:
> https://wiki.documentfoundation.org/Development/GetInvolved

I will do that. Thanks.
Comment 7 Jean-Louis Fuchs 2020-03-24 20:28:43 UTC
I opened a merge request on gerrit:

https://gerrit.libreoffice.org/c/core/+/90427
Comment 8 Julien Nabet 2020-03-24 21:11:22 UTC
Thank you Jean-Louis for the patch.
Let's wait for Jenkins tests first then a review from devs.
Comment 9 Jean-Louis Fuchs 2020-03-24 22:45:41 UTC
(In reply to Julien Nabet from comment #8)
> Thank you Jean-Louis for the patch.
> Let's wait for Jenkins tests first then a review from devs.

How do you get reviews from devs? It is now 12 days ago since Jenkins is done.
Comment 10 Commit Notification 2020-03-25 21:39:51 UTC
Jean-Louis Fuchs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6cd926f385d0cd2656ce69b3c2efbdc35ee7da44

tdf#131153 Correct LongDateDaySeparator for fr_CH and it_CH

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2020-07-22 15:03:06 UTC
A polite ping to Jean-Louis Fuchs:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks
Comment 12 Jean-Louis Fuchs 2020-07-22 15:12:14 UTC
(In reply to Xisco Faulí from comment #11)
> A polite ping to Jean-Louis Fuchs:
> Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
> Otherwise, Could you please explain what's missing?
> Thanks

Thanks for pinging. I tested the behavior with the latest release. It is correct.
Jean