Bug 131162 - UI Entries cropped in Tools/Option/Draw/General
Summary: UI Entries cropped in Tools/Option/Draw/General
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.4.1.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-03-05 16:44 UTC by Julien Nabet
Modified: 2021-07-17 10:28 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
French UI (19.19 KB, image/png)
2020-03-05 16:44 UTC, Julien Nabet
Details
English US UI (18.53 KB, image/png)
2020-03-05 16:45 UTC, Julien Nabet
Details
Impress General page after the patch (left) vs in bibisect 7.2 (right) (232.29 KB, image/png)
2021-04-21 15:23 UTC, Gabor Kelemen (allotropia)
Details
Draw's General page after the patch (left) vs in bibisect 7.2 (right) (197.58 KB, image/png)
2021-04-21 15:24 UTC, Gabor Kelemen (allotropia)
Details
Impress General page in bibisect 7.2 (left) after the patch (right) 2nd try (223.87 KB, image/png)
2021-04-22 12:54 UTC, Gabor Kelemen (allotropia)
Details
Draw's General page in bibisect 7.2 (left) vs after the patch (right) 2nd try (186.68 KB, image/png)
2021-04-22 12:57 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nabet 2020-03-05 16:44:15 UTC
Description:
On Win10 with master sources updated today, UI Entries in Tools/Option/Draw/General are cropped with French UI and Spanish UI at least.
With EnglishUS, it's less visible.

Steps to Reproduce:
1. Open Draw
2. Tools/Options/Draw/General


Actual Results:
Entries cropped

Expected Results:
Entries not cropped


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version : 7.0.0.0.alpha0+ (x64)
Build ID : e0b7d6d9b7c7f3a0e7c5bdc4aad84b45c10e62af
Threads CPU : 4; OS : Windows 10.0 Build 18362; UI Render : Skia/Vulkan; VCL: win; 
Locale : fr-FR (fr_FR); Langue IHM : fr-FR
Calc: threaded
Comment 1 Julien Nabet 2020-03-05 16:44:44 UTC
Created attachment 158416 [details]
French UI
Comment 2 Julien Nabet 2020-03-05 16:45:00 UTC
Created attachment 158417 [details]
English US UI
Comment 3 Julien Nabet 2020-03-05 16:46:03 UTC
Caolán: thought you may be interested in this one since it could be related to welding process (https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca6574af948f473691d331f0f2ccf17907465c9e)
Comment 4 Caolán McNamara 2020-03-06 12:15:00 UTC
I imagine this became a problem at

commit 208b3a9bff95e2f6151c2458cf7eefe43dafa20e
Author: andreas kainz <kainz.a@gmail.com>
Date:   Wed Nov 6 00:25:25 2019 +0100

    Impress Options Dialog General update
    
    Change-Id: I019cba1f1e0031ea16b4c69f3ed2f41a1bd6a39f
    Reviewed-on: https://gerrit.libreoffice.org/82110
    Tested-by: Jenkins
    Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Comment 5 Caolán McNamara 2020-03-06 12:31:12 UTC
maybe, to fit in that long string a layout of...

row 1: impress "new document" and "presentation"
row 2: "settings" and "text objects", with draw's "scale" under "text objects"
row 3: "compatability" on a row on its own to fit in the huge text

would work ?
Comment 6 andreas_k 2020-03-06 21:34:20 UTC
(In reply to Caolán McNamara from comment #5)
> maybe, to fit in that long string a layout of...
> 
> row 1: impress "new document" and "presentation"
> row 2: "settings" and "text objects", with draw's "scale" under "text
> objects"
> row 3: "compatability" on a row on its own to fit in the huge text
> 
> would work ?

Thanks for the bug report. Arrangement as written above will work better. Will submit the patch asap.
Comment 7 Xisco Faulí 2020-07-22 15:13:55 UTC
Dear Andreas Kainz,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.
Comment 8 Gabor Kelemen (allotropia) 2021-04-21 15:23:56 UTC
Created attachment 171337 [details]
Impress General page after the patch (left) vs in bibisect 7.2 (right)

Proposed patch:
https://gerrit.libreoffice.org/c/core/+/114445/1
Comment 9 Gabor Kelemen (allotropia) 2021-04-21 15:24:31 UTC
Created attachment 171338 [details]
Draw's General page after the patch (left) vs in bibisect 7.2 (right)
Comment 10 andreas_k 2021-04-21 15:29:07 UTC
(In reply to Gabor Kelemen from comment #9)
> Created attachment 171338 [details]
> Draw's General page after the patch (left) vs in bibisect 7.2 (right)

can you move the compatibility section to the bottom and two columns width, cause the label is very long. But I like the improvement.
Comment 11 Gabor Kelemen (allotropia) 2021-04-21 16:06:10 UTC
(In reply to andreas_k from comment #10)
> (In reply to Gabor Kelemen from comment #9)
> > Created attachment 171338 [details]
> > Draw's General page after the patch (left) vs in bibisect 7.2 (right)
> 
> can you move the compatibility section to the bottom and two columns width,
> cause the label is very long. But I like the improvement.

It's just like that - the left side window with German UI (since those translations are longer) is the new version :).
Comment 12 andreas_k 2021-04-21 17:34:05 UTC
I prefer the right layout, but with compatibility bottom left.
Comment 13 Gabor Kelemen (allotropia) 2021-04-22 12:54:49 UTC
Created attachment 171353 [details]
Impress General page in bibisect 7.2 (left) after the patch (right)  2nd try

Uploaded another iteration to Gerrit to implement the layout suggested in comment #5

Current:
New Document
Text Objects | Presentation
Settings | Compatibility

New:
New Document  | Presentation
Settings | Text Objects
Compatibility
Comment 14 Gabor Kelemen (allotropia) 2021-04-22 12:57:22 UTC
Created attachment 171354 [details]
Draw's General page in bibisect 7.2 (left) vs after the patch (right) 2nd try

Current:
Text Objects
Settings | Compatibility
Scale

New:
Settings | Text Objects
         | Scale
Compatibility
Comment 15 Commit Notification 2021-04-29 10:47:57 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b49eca55210d3f7e731f32f2f20bd12bfd729ec6

tdf#131162 Rearrange Impress/Draw General settings page

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 NISZ LibreOffice Team 2021-05-05 15:09:02 UTC
Verified in: 

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ef78c7d93e4f170ac7a7f0307a8305052524eb53
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: ug-CN (hu_HU); UI: hu-HU
Calc: threaded