Bug 131171 - Slide animation "diagonal squares" has wrong labels for directions
Summary: Slide animation "diagonal squares" has wrong labels for directions
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.3.5.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Katarina Behrens
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords: skillUI
Depends on:
Blocks: Sidebar-Animation
  Show dependency treegraph
 
Reported: 2020-03-05 21:33 UTC by Oliver Grimm
Modified: 2021-04-13 18:48 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Grimm 2020-03-05 21:33:15 UTC
Description:
The german translations for the available directions in the form animation dialog "Auftritt | Diagonale Kästen" are wrong. 

Steps to Reproduce:
1. open a new odp file
2. draw a new form
3. select side panel | animation
4. press "+" for "add effect"
5. select effect "Diagonale Kästen"
6. try different settings for "direction" and observe the demo animation

Actual Results:
The demo animation directions do not resemble the german descriptions.

Expected Results:
The animation should resemble the selected drop down entry.

To my understanding the drop down labels for "direction" should be changed as

"von rechts nach oben" --> "von links unten"
"von rechts nach unten" --> "von links oben"
"von links nach oben" --> "von rechts unten"
"von links nach unten" --> "von rechts oben"



Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.1.2
Build-ID: 1:6.4.1-1
CPU-Threads: 2; BS: Linux 5.4; UI-Render: Standard; VCL: kf5; 
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded
Comment 1 Ming Hua 2020-03-05 22:34:29 UTC
(In reply to Oliver Grimm from comment #0)
> To my understanding the drop down labels for "direction" should be changed as
> 
> "von rechts nach oben" --> "von links unten"
This specific translation is the following link on Weblate, keyID RCE8f:
https://translations.documentfoundation.org/translate/libo_ui-6-4/officecfgregistrydataorgopenofficeofficeui/de/?checksum=b8b1cf3409875a38

A machine translation website told me the German translator is correct to translate English "from right to top" to German "Von rechts nach oben".  Do you agree?  If so, it is not a German specific issue and likely affects all languages.

> "von rechts nach unten" --> "von links oben"
> "von links nach oben" --> "von rechts unten"
> "von links nach unten" --> "von rechts oben"
Comment 2 Oliver Grimm 2020-03-06 21:03:59 UTC
Well, the translation itself is correct as it is used currently.

But when I look at the effect, it is starting in one corner of the object and then the animation is moving diagonally towards the opposite corner.

You are right: since the translation is correct, the english description itself is wrong.

The english labels should be changed as follows to reflect what's happening on the screen:

"from right to top" --> "from bottom left"
"from right to bottom" --> "from top left"
"from left to top" --> "from bottom right"
"from left to bottom" --> "from top right"

After fixing the english labels all translations should be fixed accordingly, of course.

Thank you for pointing that out.
Comment 3 Ming Hua 2020-03-07 02:45:22 UTC
Reproduced in 6.3.5:

Version: 6.3.5.2 (x64)
Build ID: dd0751754f11728f69b42ee2af66670068624673
CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: zh-CN (zh_CN); UI-Language: en-US
Calc: threaded
Comment 4 Oliver Grimm 2020-03-07 21:08:06 UTC
Thanks for adjusting the title of the bug report.

To be precise: this is not about the the animation for the whole slide but for a single drawing object. So I'd rather phrase it as "object animation" or something similar in the bug title. What is the best word to use (referring to an english UI) so everyone knows what we are talking about here?
Comment 5 Ming Hua 2020-03-08 04:54:15 UTC
(In reply to Oliver Grimm from comment #4)
> To be precise: this is not about the the animation for the whole slide but
> for a single drawing object. So I'd rather phrase it as "object animation"
> or something similar in the bug title. What is the best word to use
> (referring to an english UI) so everyone knows what we are talking about
> here?
The animation between slides are called "transition" in the UI, so I think the title is clear enough.  Maybe just "animation" is better, I'm not sure.
Comment 6 Commit Notification 2021-04-12 17:23:55 UTC
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/46fe595379a898ee7e537cbffd5d215d4a58aca5

tdf#131171: make Diagonal Squares animations behave as described

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-04-13 18:48:23 UTC
Katarina Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/d72a592e2220974444146f5f4e76d6135af60ef9

tdf#131171: make Diagonal Squares animations behave as described

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.