Bug 131327 - AUTO-REDACT: double click to edit target
Summary: AUTO-REDACT: double click to edit target
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks: Redaction
  Show dependency treegraph
 
Reported: 2020-03-13 09:53 UTC by guser
Modified: 2022-04-03 16:33 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description guser 2020-03-13 09:53:29 UTC
Description:
Add support to double click to open Edit target dialog in Automatic Redaction window.

Steps to Reproduce:
1. run Writer
2. click Tools > Auto-Redact
3. in Automatic Redaction dialog double click to item in Redaction Targets list

Actual Results:
Edit Target window is not open

Expected Results:
open Edit Target window


Reproducible: Always


User Profile Reset: No



Additional Info:
n/a
Comment 1 Muhammet Kara 2020-03-18 18:13:19 UTC
Seems like a valid request.
Comment 2 Muhammet Kara 2020-06-29 18:38:04 UTC
(In reply to Muhammet Kara from comment #1)
> Seems like a valid request.

Code pointers:

Add a double click handler for the redaction targets list (m_xTargetsBox), and call the EditHdl handler from there.

Source code: sfx2/source/doc/autoredactdialog.cxx
Header file: sfx2/inc/autoredactdialog.hxx
Comment 3 Nihal Jain 2020-10-05 12:14:58 UTC
Hi! I would like to try to work through this. I am new here, so I am not sure about how to go about getting this assigned to me. It would be great to get some idea about the workflow and also if this issue is still open. Thanks!
Comment 4 Buovjaga 2020-10-05 12:17:50 UTC
(In reply to Nihal Jain from comment #3)
> Hi! I would like to try to work through this. I am new here, so I am not
> sure about how to go about getting this assigned to me. It would be great to
> get some idea about the workflow and also if this issue is still open.
> Thanks!

Change assignee to your email and the status to assigned
Comment 5 Sumit Sahu 2020-12-26 13:33:52 UTC
Can I work on this ?
Comment 6 Buovjaga 2020-12-26 13:40:21 UTC
(In reply to Sumit Sahu from comment #5)
> Can I work on this ?

As 3 months have passed without Nihal doing anything, yes, you can take this.
Comment 7 Sumit Sahu 2020-12-29 06:43:49 UTC
I sent following patch for this bug;
https://gerrit.libreoffice.org/c/core/+/108420
Comment 8 Buovjaga 2021-01-13 14:20:56 UTC
(In reply to Sumit Sahu from comment #7)
> I sent following patch for this bug;
> https://gerrit.libreoffice.org/c/core/+/108420

I built with the patch and I confirm it works as expected. I hope someone can review it.
Comment 9 CHAYAN DAS 2021-02-08 18:14:07 UTC
Hello!
I'd like to get involved with the open source community. Would this fix be a reasonable place to make my first contribution? I am confused from where to get started.
Comment 10 Buovjaga 2021-02-08 18:31:44 UTC
(In reply to CHAYAN DAS from comment #9)
> Hello!
> I'd like to get involved with the open source community. Would this fix be a
> reasonable place to make my first contribution? I am confused from where to
> get started.

No, Sumit has a rather recent patch that is just waiting for review. Btw. I invited you to an interview.
Comment 11 Muhammet Kara 2021-08-21 20:33:31 UTC
Resetting due to inactivity. For anyone who would like to take this task. Just check out this patch, and take the review coments there into account: https://gerrit.libreoffice.org/c/core/+/108420
Comment 12 Radhey Parekh 2021-08-27 07:31:26 UTC Comment hidden (obsolete)
Comment 13 Radhey Parekh 2021-08-27 07:31:49 UTC Comment hidden (obsolete)
Comment 14 Muhammet Kara 2021-08-27 08:54:37 UTC
(In reply to Radhey Parekh from comment #13)
> I would like to work on this issue.

Please, go ahead. Don't forget to assign the bug to yourself.
Comment 15 Lai-Verne 2021-10-07 08:46:54 UTC
Hi!I want to solve this issue. I am new here
But I will try my best.Thanks!
Comment 16 Lai-Verne 2021-10-14 01:24:57 UTC
I have uploaded this code.
Please check.
https://gerrit.libreoffice.org/c/core/+/123570
Comment 17 Commit Notification 2022-01-24 22:03:36 UTC
Verne-Lai committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/687cfd51ac785c2ab2cb8e49dea28aa7f53cbdfb

tdf#131327 Add double clicked event on auto-redact table

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Buovjaga 2022-02-03 16:05:21 UTC
Should this be closed as fixed?
Comment 19 Roman Kuznetsov 2022-04-03 16:33:31 UTC
verified in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a3988b2d147a2442b348d58b79dbd6e71472b7af
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL Jumbo

Thanks for fixing!