Description: The libpoppler API has changed. LinkURI::getURI() now returns a std::string value. Steps to Reproduce: Build libreoffice core against poppler >= 0.86.0 Actual Results: /home/iurt/rpmbuild/BUILD/libreoffice-6.4.1.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx: In member function 'virtual void pdfi::PDFOutDev::processLink(AnnotLink*)': /home/iurt/rpmbuild/BUILD/libreoffice-6.4.1.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:567:64: error: base operand of '->' has non-pointer type 'const string' {aka 'const std::__cxx11::basic_string<char>'} 567 | const char* pURI = static_cast<LinkURI*>(pAction)->getURI()->c_str(); | ^~ Expected Results: No compile error. Reproducible: Always User Profile Reset: No Additional Info: N/A
Created attachment 158698 [details] Suggested fix This patch fixes the build error. I've not tested run-time behaviour, but it mirrors the changes made in https://gitlab.freedesktop.org/poppler/poppler/-/commit/5804f51c7cf439432082b668ba8df3b0a6048caf, so is likely correct.
(In reply to Martin Whitaker from comment #1) > Created attachment 158698 [details] > Suggested fix > > This patch fixes the build error. I've not tested run-time behaviour, but it > mirrors the changes made in > https://gitlab.freedesktop.org/poppler/poppler/-/commit/ > 5804f51c7cf439432082b668ba8df3b0a6048caf, so is likely correct. Could you submit the patch to gerrit for review: https://wiki.documentfoundation.org/Development/gerrit ? Thanks. We also need a license statement: https://wiki.documentfoundation.org/Development/GetInvolved#License_statement
Martin: could you provide license statement as Buovjaga indicated with https://wiki.documentfoundation.org/Development/GetInvolved#License_statement ? Indeed, since it's your first proposed patch, we need it.
A trivial change like that would not be subject to copyright, but I hereby place it in the public domain for anyone to use.
(In reply to Martin Whitaker from comment #4) > A trivial change like that would not be subject to copyright, but I hereby > place it in the public domain for anyone to use. It would need to be under the MPLv2/LGPLv3+ dual license and sent to the dev list, sorry for the trouble :(
@Martin, assigning this bug to you. Could you please send the license statement as described here https://wiki.documentfoundation.org/Development/GetInvolved#License_statement? We can send the submit the patch to gerrit for you if you prefer so
*** Bug 133234 has been marked as a duplicate of this bug. ***
(In reply to Xisco Faulí from comment #6) > @Martin, assigning this bug to you. > Could you please send the license statement as described here > https://wiki.documentfoundation.org/Development/ > GetInvolved#License_statement? > We can send the submit the patch to gerrit for you if you prefer so The patch was already sent to gerrit: [1]. Can we move it forward? My local build is failing and it is annoying to keep the patch around. Thanks! [1] https://gerrit.libreoffice.org/c/core/+/93789
(In reply to DavidO from comment #8) > (In reply to Xisco Faulí from comment #6) > > @Martin, assigning this bug to you. > > Could you please send the license statement as described here > > https://wiki.documentfoundation.org/Development/ > > GetInvolved#License_statement? > > We can send the submit the patch to gerrit for you if you prefer so > > The patch was already sent to gerrit: [1]. Can we move it forward? > My local build is failing and it is annoying to keep the patch around. > Thanks! > > [1] https://gerrit.libreoffice.org/c/core/+/93789 I've restored the patch in gerrit. See Rene's commit.
(In reply to Xisco Faulí from comment #9) > (In reply to DavidO from comment #8) > > (In reply to Xisco Faulí from comment #6) > > > @Martin, assigning this bug to you. > > > Could you please send the license statement as described here > > > https://wiki.documentfoundation.org/Development/ > > > GetInvolved#License_statement? > > > We can send the submit the patch to gerrit for you if you prefer so > > > > The patch was already sent to gerrit: [1]. Can we move it forward? > > My local build is failing and it is annoying to keep the patch around. > > Thanks! > > > > [1] https://gerrit.libreoffice.org/c/core/+/93789 > > I've restored the patch in gerrit. See Rene's commit. Thanks. Was the license issue clarified? Can that patch be approved?
Martin Whitaker committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b42ab78fb871924896b3cc38a7b2f1257151f711 tdf#131353: Fix build with poppler 0.86.0 It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Given the size (and obviousness) of the patch and the relatively large impact (is any Linux distro out there still on poppler < 0.86.0? I doubt it...), shouldn't this be fixed in the 7.0.0 branch as well?
Apparently that patch now was commited without a license statement. Ah, well. Wrt cherry-picking: I agree, for 6.4.5 even. https://gerrit.libreoffice.org/c/core/+/96588 https://gerrit.libreoffice.org/c/core/+/96639 https://gerrit.libreoffice.org/c/core/+/96640 (But yes, there definitely is Linux distros out there still on poppler < 0.86.0)
Martin Whitaker committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/0a3c7a726ee7b26ce1014083f1087747cbde9277 tdf#131353: Fix build with poppler 0.86.0 It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
For the record, it is acceptable to us for contributors to dedicate their patches to the public domain.
Martin Whitaker committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/d40f36bf47814c324a1ec467c566255fb187444b tdf#131353: Fix build with poppler 0.86.0 It will be available in 6.4.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Martin Whitaker committed a patch related to this issue. It has been pushed to "libreoffice-6-4-5": https://git.libreoffice.org/core/commit/0c27277b90c9ddd6d16c66b895f56739c791d705 tdf#131353: Fix build with poppler 0.86.0 It will be available in 6.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.