Bug 131537 - FILESAVE DOCX OLE objects “Display as icon” setting ignored on opening
Summary: FILESAVE DOCX OLE objects “Display as icon” setting ignored on opening
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: medium normal
Assignee: Dániel Arató (NISZ)
URL:
Whiteboard: target:7.1.0 target:7.0.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-OLE-Objects
  Show dependency treegraph
 
Reported: 2020-03-24 14:42 UTC by NISZ LibreOffice Team
Modified: 2020-09-16 11:55 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer (29.02 KB, application/vnd.oasis.opendocument.text)
2020-03-24 14:42 UTC, NISZ LibreOffice Team
Details
The original file saved by Writer (18.71 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-03-24 14:43 UTC, NISZ LibreOffice Team
Details
Screenshot of the original and exported document side by side in Writer (94.63 KB, image/png)
2020-03-24 14:44 UTC, NISZ LibreOffice Team
Details
how it looks (273.38 KB, image/png)
2020-09-11 19:18 UTC, BogdanB
Details
screenshot (55.60 KB, image/png)
2020-09-14 15:49 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-03-24 14:42:54 UTC
Created attachment 158939 [details]
Example file from Writer

When saving OLE objects that were inserted into a new Writer document with “Display as icon” option set in the “Insert OLE object” dialog, the setting is not considered when opening the resulting DOCX file: the OLE is opened not as icon, but in-place editable object.
Word on the other hand opens the file with the OLE icon.


Steps to reproduce:
1.	In Writer choose Insert – Object – OLE Object.
2.	Choose Create from file, select an existing XLSX/XLS file
3.	Check the “Display as icon” box.
4.	The file is inserted as an icon, instead of an editable content box.
5.	Save as DOCX and reopen in Writer

Actual results:
The embedded file is opened in Writer as an editable content box, with the size of the original OLE icon.

Expected results:
The OLE object is correctly saved as icon, Word opens the file with an OLE icon. Writer should too.

LibreOffice details:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 8e323fcacebad1afe9d867b846722a6b9bf20f78
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Also happens in:
Verzió: 6.0.0.3
Build az.: 64a0f66915f38c6217de274f0aa8e15618924765
CPU szálak: 4; OS: Windows 6.3; Felületmegjelenítés: alapértelmezett; 
Területi beállítások: hu-HU (hu_HU); Calc: CL

Save and reload was good in: 
Version: 5.4.0.3
Build ID: 92c2794a7c181ba4c1c5053618179937228ed1fb
CPU threads: 4; OS: Windows 6.2; UI render: default; 
Locale: en-US (hu_HU); Calc: CL

Bibisected using bibisect-win32-6.0 to: 
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=505ce3a2ba3adeef46daecbf9b14c42cea211408 

author	Szymon Kłos <szymon.klos@collabora.com>	2017-07-07 12:58:42 +0200
committer	Szymon Kłos <szymon.klos@collabora.com>	2017-07-08 09:28:09 +0200
summary: tdf#108544 edit in window (XLSX inside DOCX)

Adding CC to: Szymon Kłos
Comment 1 NISZ LibreOffice Team 2020-03-24 14:43:14 UTC
Created attachment 158940 [details]
The original file saved by Writer
Comment 2 NISZ LibreOffice Team 2020-03-24 14:44:15 UTC
Created attachment 158941 [details]
Screenshot of the original and exported document side by side in Writer
Comment 3 Dieter 2020-03-27 08:12:10 UTC
I confirm it with

Version: 6.3.5.2 (x64)
Build-ID: dd0751754f11728f69b42ee2af66670068624673
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 4 Commit Notification 2020-09-03 16:36:01 UTC
Daniel Arato (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/07dcb0dab759d4ab535d99c0e6d326959906b87e

tdf#131537 DOCX export: fix OLE "Display as icon"

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 BogdanB 2020-09-11 19:18:06 UTC
Created attachment 165408 [details]
how it looks

This is how it looks on my
Version: 7.1.0.0.alpha0+
Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded

It seems not solved...
Comment 6 BogdanB 2020-09-11 19:18:25 UTC
or maybe I missed something...
Comment 7 Dániel Arató (NISZ) 2020-09-14 14:42:20 UTC
(In reply to BogdanB from comment #5)

This was an export issue, rather than an import one. That is to say the attached example file already _has_ the problem. You need to create a new document with an OLE in it from scratch, save it and then reopen it to test the behaviour.
Comment 8 BogdanB 2020-09-14 15:49:23 UTC
Created attachment 165500 [details]
screenshot

This is how it looks after reopening with LibreOffice, like an icon.
So, it's verified now.
Comment 9 BogdanB 2020-09-14 15:49:47 UTC
Verified with
Version: 7.1.0.0.alpha0+
Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 10 Commit Notification 2020-09-16 11:55:55 UTC
Daniel Arato (NISZ) committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/10184fcab1f314e0861ad152b320ed1ee31ccdd5

tdf#131537 DOCX export: fix OLE "Display as icon"

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.