Description: Hang/Freeze pressing Search in Expert Configuration without search string Steps to Reproduce: 1. Open Writer 2. Tools -> Options -> Advanced -> Expert Configuration 3. Press Search button Actual Results: Hang/Freeze Expected Results: No hang/freeze Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha0+ (x64) Build ID: 7ae9c9572ccac55c0926b8a9779bb63c4236291c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
On pc Debian x86-64 with master sources updated today, I noticed this little hang.
Created attachment 159011 [details] Flamegraph Here's a Flamegraph Code pointer: IMPL_LINK_NOARG( CuiAboutConfigTabPage, SearchHdl_Impl, weld::Button&, void) See https://opengrok.libreoffice.org/xref/core/cui/source/options/optaboutconfig.cxx?r=175a2063#788
Works for me in Version: 7.1.0.0.alpha0+ Build ID: e2f4e65a7b8024c00b049eebf0d87637efda7f24 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Please retest, thank you
still repro Version: 7.1.0.0.alpha0+ (x64) Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
bisected to: 80b1b645ad77f30e6ebc97c1f0d2c4e3880de359 is the first bad commit commit 80b1b645ad77f30e6ebc97c1f0d2c4e3880de359 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Tue Nov 26 22:51:19 2019 -0800 source 3b0d29f1461c97c0c812a500b3414b9a50d694ff https://gerrit.libreoffice.org/c/core/+/83668 Adding CC to: Caolán McNamara
I note the bisect refers to a fast, but broken state
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8b806dc8dc5671090b129a3c4b2cde7171114817 tdf#131581 inhibit updates during all_foreach It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that makes it quite responsive, backport to 7-0 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dffad40a50c42bd427dd0153d0022c4ec80cb93a Related: tdf#131581 inhibit updates during other for_each variants It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 7.1.0.0.alpha0+ Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, thanks for fixing this issue!
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/b19e522654562b8f01d0b3af4078c43ce46834e4 tdf#131581 inhibit updates during all_foreach It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f33c253ee9572ce83016e527ab0d050aab71a674 tdf#131581: sw: Add UItest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Seems the this patch causes Navigator content tree view flash when using x11 backend. Flashing doesn't happen after I comment out UpdateGuard in vcl/source/app/salvtables.cxx virtual void all_foreach(const std::function<bool(weld::TreeIter&)>& func) override { //UpdateGuard aGuard(*m_xTreeView);
how about with https://gerrit.libreoffice.org/c/core/+/104381 ?
Caolán McNamara from comment #14) > how about with https://gerrit.libreoffice.org/c/core/+/104381 ? Unfortunately the same flashing occurs with the patch applied :( A workaround patch is given at Bug 136962 report.
and with https://gerrit.libreoffice.org/c/core/+/105487 ?
(In reply to Caolán McNamara from comment #16) > and with https://gerrit.libreoffice.org/c/core/+/105487 ? Fixed!