Bug 131688 - RemoveDirectCharFormats <Ctrl>+<Shift>+X usage tip
Summary: RemoveDirectCharFormats <Ctrl>+<Shift>+X usage tip
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low trivial
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Tip-Of-The-Day
  Show dependency treegraph
 
Reported: 2020-03-30 00:21 UTC by TorrAB
Modified: 2023-05-12 09:52 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
file with altered (bold, big) chars (13.82 KB, application/vnd.oasis.opendocument.text)
2020-03-30 00:21 UTC, TorrAB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2020-03-30 00:21:51 UTC
Created attachment 159133 [details]
file with altered (bold, big) chars

In boldNor.odt,
	0. cursor after 'a', hit h: 'h' Bold & big, as expected.
	1. cursor after 'b', hit ^m (or Format>Clear Direct Formatting), then y: 'y' Normal (not Bold, size 12) —OK.
	2. cursor after 'c', hit ^X (ctrl_shift_x; RemoveDirectCharFormats; Tip № 65), then v: 'v' Bold & big (like 'c'), unexpected; ^X did not work.
	3. cursor after 'd', hit ^X (as in step2), then p: 'p' Normal (not Bold) —OK.
	4. cursor after 'e', hit ^m (as in step2), then q: 'q' Normal (not Bold) —OK.
	5. cursor after 'f', hit ^X: nothing happens; hit 'g': g Bold. Word is now 'fgh'.
	6. cursor after 'f', hit ^m: 'fgh' becomes Normal, because cursor is inside a word; OK.
	Conclusion: ^X works only at the end of a parag —steps 2, 3, 5. ^m (Clear Direct Formatting) apparently does the same thing, but better —steps 1, 4, 6. Function RemoveDirectCharFormats can be eliminated.
Comment 1 Heiko Tietze 2020-04-03 09:50:55 UTC
Stuart, what do you think?
Comment 2 V Stuart Foote 2020-04-03 16:20:48 UTC
The function remains valid as implemented for OOo (see also i13592), just being misapplied by OP.

Review of the control [1] shows it is intended to be applied when positioned at the end of a Paragraph--to prevent the continuation of the Direct Formatting from that point should additional text be added.

See no reason to remove, and its writer shell action DontExpandFormat() might be another tool to solve other paste with/without formatting issues. 

The tip-of-the-day string for it [2] probably needs a tweak--"Typing new paragraph text in..."

=-ref-=

[1] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/shells/txtattr.cxx?r=a01a5bd9#192
[2] https://opengrok.libreoffice.org/xref/core/cui/inc/tipoftheday.hrc?r=a504ed78#112

 { NC_("RID_CUI_TIPOFTHEDAY", "Typing in bold, italics, or underlined in Writer you can continue with the default attributes using just the shortcut %MOD1+Shift+X (remove direct character formats)."), "", "tipoftheday_w.png"},
Comment 3 Heiko Tietze 2020-04-06 09:40:42 UTC
(In reply to V Stuart Foote from comment #2)
> The tip-of-the-day string for it [2] probably needs a tweak...

Let's do this. Seth, a job for you?
Comment 4 Heiko Tietze 2021-06-17 05:28:06 UTC
Customization of .uno:RemoveDirectCharFormats into the toolbar (menu probably too) is possible but not effective. We should block it in sw/sdi/swriter SfxVoidItem RemoveDirectCharFormats FN_REMOVE_DIRECT_CHAR_FORMATS > MenuConfig, ToolBoxConfig

And the TotD needs improvement, search cui/inc/tipoftheday.hrc for "Typing in bold, italics, or underlined in Writer".
Comment 5 Commit Notification 2022-11-08 09:37:17 UTC
Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3c4ee1f180aed4bc09cf8dab2a1101feb0d95fa6

tdf#131688 Improve one tip of the day

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 BogdanB 2022-11-08 09:49:40 UTC
Second part of comment 4 is solved. Remains the first part.

Heiko, if this is just a half solved job how I should mark the bug?