Bug 131868 - Presentation with existing "mouse as pen" shapes is marked modified after presenting it
Summary: Presentation with existing "mouse as pen" shapes is marked modified after pre...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected)
4.2 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
Depends on:
Blocks: ModifiedStatus
  Show dependency treegraph
Reported: 2020-04-04 08:47 UTC by Jan-Marek Glogowski
Modified: 2022-06-02 17:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By: Thorsten Behrens

Presentation with "mouse as pen" shapes (14.85 KB, application/vnd.oasis.opendocument.presentation)
2020-04-04 08:47 UTC, Jan-Marek Glogowski

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Marek Glogowski 2020-04-04 08:47:02 UTC
Created attachment 159314 [details]
Presentation with "mouse as pen" shapes

While bibisecting bug 129898, I found that my test presentation would automatically be set as modified, after closing the presentation mode, without having done any changes.

To reproduce:

1. Open the attached presentation (and you'll notice bug 129898 too)
2. Start the presentation (F5)
3. Finish the presentation using the keyboard (space), so you won't accidentally draw something.

Actual result: the presentation is modified and you will get asked to save the changes when closing it

Expected result: no modification to the presentation, no dialog on close

This was introduced by:

    commit 516ecd072f9dbfbacce77127a02b666ce387982d
    Author:     Thorsten Behrens <tbehrens@suse.com>
    AuthorDate: Fri Oct 11 18:07:37 2013 +0200
    Commit:     Thorsten Behrens <thb@documentfoundation.org>
    CommitDate: Fri Oct 11 18:10:05 2013 +0200
        Restore persistent userpaint functionality in slideshow.

CC thorsten

You'll also notice, that finishing the presentation mode has now quite a lag after this commit. Copying the drawing from the presentation window seems very slow, which showing the presentation with the drawing on it, still feels instant.
Comment 1 Xisco Faulí 2020-05-13 11:40:30 UTC
Reproduced in

Build ID: 1ffe59ef31186e36ad0aa7bbcdd32e407ee8d26c
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Adding Cc: to Thorsten Behrens
Comment 2 Regina Henschel 2020-05-13 13:54:17 UTC
With my fix for bug 129898 the file is indeed changed, because the fix contains a part, which repairs the display state for layer DrawnInSlideshow.

In file it is in part styles.xml > node office:master.styles > node draw:layer-set > last of nodes draw:layer. There the attribute draw:display="none" is removed.
And in part settings.xml the config-items PrintableLayers and VisibleLayers are changed accordingly too.