Bug 131868 - Presentation with existing "mouse as pen" shapes is marked modified after presenting it
Summary: Presentation with existing "mouse as pen" shapes is marked modified after pre...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.2 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: ModifiedStatus
  Show dependency treegraph
 
Reported: 2020-04-04 08:47 UTC by Jan-Marek Glogowski
Modified: 2024-06-02 03:14 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Presentation with "mouse as pen" shapes (14.85 KB, application/vnd.oasis.opendocument.presentation)
2020-04-04 08:47 UTC, Jan-Marek Glogowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Marek Glogowski 2020-04-04 08:47:02 UTC
Created attachment 159314 [details]
Presentation with "mouse as pen" shapes

While bibisecting bug 129898, I found that my test presentation would automatically be set as modified, after closing the presentation mode, without having done any changes.

To reproduce:

1. Open the attached presentation (and you'll notice bug 129898 too)
2. Start the presentation (F5)
3. Finish the presentation using the keyboard (space), so you won't accidentally draw something.

Actual result: the presentation is modified and you will get asked to save the changes when closing it

Expected result: no modification to the presentation, no dialog on close

This was introduced by:

    commit 516ecd072f9dbfbacce77127a02b666ce387982d
    Author:     Thorsten Behrens <tbehrens@suse.com>
    AuthorDate: Fri Oct 11 18:07:37 2013 +0200
    Commit:     Thorsten Behrens <thb@documentfoundation.org>
    CommitDate: Fri Oct 11 18:10:05 2013 +0200
    
        Restore persistent userpaint functionality in slideshow.

CC thorsten

You'll also notice, that finishing the presentation mode has now quite a lag after this commit. Copying the drawing from the presentation window seems very slow, which showing the presentation with the drawing on it, still feels instant.
Comment 1 Xisco Faulí 2020-05-13 11:40:30 UTC
Reproduced in

Version: 7.0.0.0.alpha1+
Build ID: 1ffe59ef31186e36ad0aa7bbcdd32e407ee8d26c
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Adding Cc: to Thorsten Behrens
Comment 2 Regina Henschel 2020-05-13 13:54:17 UTC
With my fix for bug 129898 the file is indeed changed, because the fix contains a part, which repairs the display state for layer DrawnInSlideshow.

In file it is in part styles.xml > node office:master.styles > node draw:layer-set > last of nodes draw:layer. There the attribute draw:display="none" is removed.
And in part settings.xml the config-items PrintableLayers and VisibleLayers are changed accordingly too.
Comment 3 QA Administrators 2024-06-02 03:14:26 UTC
Dear Jan-Marek Glogowski,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug