Bug 131937 - Adding or removing "Split Window" does not flag the file as changed
Summary: Adding or removing "Split Window" does not flag the file as changed
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.5.7.2 release
Hardware: All All
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ModifiedStatus
  Show dependency treegraph
 
Reported: 2020-04-06 17:31 UTC by tom
Modified: 2024-10-03 03:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tom 2020-04-06 17:31:26 UTC
Description:
When a file had no changes and thus it is not flagged as changed (The Save Icon is not indicating a necessary save) and then a existing "Freeze Rows and Columns" option is removed, the file is NOT being flagged as changed. The Save Icon is not changing status, nor is a Save dialogue triggered when the file is closed, the change is just being lost when closing the file.

Steps to Reproduce:
1. Open new spreadsheet
2. Go to B2 and select "Views > Freeze Rows and Columns"
3. Save file
4. Select "Views > Freeze Rows and Columns" again, so to remove it. The Save Icon does not change!
5. Close file. The save dialogue is not coming up
6. Open the file
7. Realize that the "Freeze Rows and Columns" in B2 is back again


Actual Results:
The step to remove "Views > Freeze Rows and Columns" is not saved and lost

Expected Results:
"Views > Freeze Rows and Columns" removal to flag the file as changed


Reproducible: Always


User Profile Reset: No



Additional Info:
1. This bug is not new and exists at least a couple of years by now, in various versions of Calc.

2. In the case that you enforce a save, although the Save Icon is not indicating changes that need to be saved, the change is saved to the file!
Comment 1 Telesto 2020-04-06 18:06:53 UTC
Repro with
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

and with
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and with
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b
Comment 2 tom 2020-04-06 18:23:47 UTC
I just noticed that a similar problem exists with adding and removing "View > Split Window". Neither adding, no removing will flag the file changed.

Since I assume that this is very related to the "Freeze Rows and Columns" bug, I did not file a new bug, but added it here.
Comment 3 Justin L 2022-10-03 23:21:41 UTC
Although bug 61060 added modification on freezing, it didn't do it for unfreezing. Proposed fix at http://gerrit.libreoffice.org/c/core/+/140932

I checked how Excel handles these, but it doesn't mark the document as changed in 2003 or 2010 for either freezing or splitting.

I realize that this is a saved setting in the document, but it is also a viewing thing. So a person reviewing a document might desire to temporarily view as a split but not intend to save. I would tend to leave it as it is, since one would RARELY change only the split and nothing else. Plus, you learn really quickly that you do need to save if it is part of your workflow to only adding splitting to a document. Best policy is leave things as they are without a clearly correct way to do it.

So I WONTFIX, but the code pointers are all there for anyone who wants to do it.
Comment 4 QA Administrators 2024-10-03 03:17:14 UTC
Dear tom,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug